Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1382)

Unified Diff: net/base/network_delegate.h

Issue 8743019: base::Bind: Convert net::NetworkDelegate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fixes. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/chrome_network_delegate.cc ('k') | net/base/network_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/network_delegate.h
diff --git a/net/base/network_delegate.h b/net/base/network_delegate.h
index 64c4918cc8c4281c45e7212a6fc2b4da8a042d9a..00bbc259aa2d28bdad47104867ac2cb22144e7b6 100644
--- a/net/base/network_delegate.h
+++ b/net/base/network_delegate.h
@@ -50,16 +50,16 @@ class NetworkDelegate : public base::NonThreadSafe {
// checking on parameters. See the corresponding virtuals for explanations of
// the methods and their arguments.
int NotifyBeforeURLRequest(URLRequest* request,
- OldCompletionCallback* callback,
+ const CompletionCallback& callback,
GURL* new_url);
int NotifyBeforeSendHeaders(URLRequest* request,
- OldCompletionCallback* callback,
+ const CompletionCallback& callback,
HttpRequestHeaders* headers);
void NotifySendHeaders(URLRequest* request,
const HttpRequestHeaders& headers);
int NotifyHeadersReceived(
URLRequest* request,
- OldCompletionCallback* callback,
+ const CompletionCallback& callback,
HttpResponseHeaders* original_response_headers,
scoped_refptr<HttpResponseHeaders>* override_response_headers);
void NotifyBeforeRedirect(URLRequest* request,
@@ -87,7 +87,7 @@ class NetworkDelegate : public base::NonThreadSafe {
// and ERR_IO_PENDING will cancel the request and report the status code as
// the reason.
virtual int OnBeforeURLRequest(URLRequest* request,
- OldCompletionCallback* callback,
+ const CompletionCallback& callback,
GURL* new_url) = 0;
// Called right before the HTTP headers are sent. Allows the delegate to
@@ -95,7 +95,7 @@ class NetworkDelegate : public base::NonThreadSafe {
// valid only until OnURLRequestDestroyed is called for this request.
// Returns a net status code.
virtual int OnBeforeSendHeaders(URLRequest* request,
- OldCompletionCallback* callback,
+ const CompletionCallback& callback,
HttpRequestHeaders* headers) = 0;
// Called right before the HTTP request(s) are being sent to the network.
@@ -113,7 +113,7 @@ class NetworkDelegate : public base::NonThreadSafe {
// |original_response_headers|.
virtual int OnHeadersReceived(
URLRequest* request,
- OldCompletionCallback* callback,
+ const CompletionCallback& callback,
HttpResponseHeaders* original_response_headers,
scoped_refptr<HttpResponseHeaders>* override_response_headers) = 0;
« no previous file with comments | « chrome/browser/net/chrome_network_delegate.cc ('k') | net/base/network_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698