ui/views/widget/native_widget_aura.cc - Issue 8741022: Implements Aura:: NativeWidgetPrivate::ReparentNativeView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/native_widget_aura.cc

Issue 8741022: Implements Aura:: NativeWidgetPrivate::ReparentNativeView (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Updated comment in sad_tab_observer Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/widget/native_widget_aura.cc

diff --git a/ui/views/widget/native_widget_aura.cc b/ui/views/widget/native_widget_aura.cc

index 7b1805e19e618da5d2093bf803acd7820315d121..083f29fc950104084cc012137713d03e30e98240 100644

--- a/ui/views/widget/native_widget_aura.cc

+++ b/ui/views/widget/native_widget_aura.cc

@@ -771,8 +771,8 @@ void NativeWidgetPrivate::GetAllChildWidgets(gfx::NativeView native_view,

// static

void NativeWidgetPrivate::ReparentNativeView(gfx::NativeView native_view,

gfx::NativeView new_parent) {

- // http://crbug.com/102576

- NOTIMPLEMENTED();

+ DCHECK(native_view != new_parent);

+ native_view->SetParent(new_parent);

Ben Goodger (Google) 2011/11/30 23:24:21 NativeWidgetWin does a lot more here, like sending

}

// static

« no previous file with comments | « chrome/browser/ui/sad_tab_observer.cc ('k') | no next file » | no next file with comments »