chrome/browser/ui/sad_tab_observer.cc - Issue 8741022: Implements Aura:: NativeWidgetPrivate::ReparentNativeView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sad_tab_observer.cc

Issue 8741022: Implements Aura:: NativeWidgetPrivate::ReparentNativeView (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Updated comment in sad_tab_observer Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/sad_tab_observer.cc

diff --git a/chrome/browser/ui/sad_tab_observer.cc b/chrome/browser/ui/sad_tab_observer.cc

index 51a788a836090e6c2eef20d886bd99bdc9cc15c6..42694596ce7e26596a3e1b99290f282753c88cce 100644

--- a/chrome/browser/ui/sad_tab_observer.cc

+++ b/chrome/browser/ui/sad_tab_observer.cc

@@ -69,8 +69,9 @@ gfx::NativeView SadTabObserver::AcquireSadTab(base::TerminationStatus status) {

SadTabView::KILLED : SadTabView::CRASHED;

views::Widget::InitParams sad_tab_params(

views::Widget::InitParams::TYPE_CONTROL);

- // It is not possible to create a widget that has no parent, and later

- // re-parent it. TODO(avi): This is a cheat. Can this be made cleaner?

+ // It is not possible to create a native_widget_win that has no parent in

+ // and later re-parent it.

+ // TODO(avi): This is a cheat. Can this be made cleaner?

sad_tab_params.parent_widget =

static_cast<TabContentsViewViews*>(tab_contents()->view());

sad_tab_params.ownership =