Remove sync OnTransaction{Start,End} notification

Remove sync OnTransaction{Start,End} notification

BUG=105814
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112556

[rlarocque, 2011-11-30 01:40:17]

Following up on http://codereview.chromium.org/8573011.

Before you approve, I recommend you spend some time playing with about:tracing
if you haven't already done so.  The justification for removing the
OnTransaction{Start,End} notifications is that their use cases are covered by
about:tracing.  You should make sure that you agree with this assertion before
agreeing to the removal of the old system.

[akalin, 2011-12-01 18:27:39]

On 2011/11/30 01:40:17, rlarocque wrote:
> Following up on http://codereview.chromium.org/8573011.
> 
> Before you approve, I recommend you spend some time playing with about:tracing
> if you haven't already done so.  The justification for removing the
> OnTransaction{Start,End} notifications is that their use cases are covered by
> about:tracing.  You should make sure that you agree with this assertion before
> agreeing to the removal of the old system.

LGTM

I think about:tracing more than covers the use cases

[commit-bot: I haz the power, 2011-12-01 18:32:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rlarocque@chromium.org/8741001/1

[commit-bot: I haz the power, 2011-12-01 18:32:08]

Presubmit check for 8741001-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
You might be calling functions intended only for testing from
production code.  It is OK to ignore this warning if you know what
you are doing, as the heuristics used to detect the situation are
not perfect.  The commit queue will not block on this warning.
Email joi@chromium.org if you have questions.
  chrome/browser/sync/syncable/syncable.cc:1842
    EntryKernel* entry = GetPossibleLastChildForTest(lock, parent_id);

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
chrome/browser/resources/sync_internals/chrome_sync.js

Presubmit checks took 1.2s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[rlarocque, 2011-12-01 18:36:54]

+jhawkins for OWNERS approval

[James Hawkins, 2011-12-01 19:38:37]

Delete moar code! LGTM

[commit-bot: I haz the power, 2011-12-01 20:49:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rlarocque@chromium.org/8741001/1

[commit-bot: I haz the power, 2011-12-01 20:53:23]

Try job failure for 8741001-1 on win_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2011-12-01 21:03:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rlarocque@chromium.org/8741001/1

[commit-bot: I haz the power, 2011-12-01 22:16:23]

Change committed as 112556