Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5518)

Unified Diff: chrome/browser/sync/js/js_mutation_event_observer.cc

Issue 8741001: Remove sync OnTransaction{Start,End} notification (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/js/js_mutation_event_observer.h ('k') | chrome/browser/sync/syncable/syncable.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/js/js_mutation_event_observer.cc
diff --git a/chrome/browser/sync/js/js_mutation_event_observer.cc b/chrome/browser/sync/js/js_mutation_event_observer.cc
index 2c323d1e054028941ec11b5ba9d4f1a81a397721..703f6e6eaefcf98653ce63eb8adf4ba0365b15d8 100644
--- a/chrome/browser/sync/js/js_mutation_event_observer.cc
+++ b/chrome/browser/sync/js/js_mutation_event_observer.cc
@@ -35,19 +35,6 @@ void JsMutationEventObserver::SetJsEventHandler(
event_handler_ = event_handler;
}
-void JsMutationEventObserver::OnTransactionStart(
- const tracked_objects::Location& location,
- const syncable::WriterTag& writer) {
- DCHECK(non_thread_safe_.CalledOnValidThread());
- if (!event_handler_.IsInitialized()) {
- return;
- }
- DictionaryValue details;
- details.SetString("location", location.ToString());
- details.SetString("writer", syncable::WriterTagToString(writer));
- HandleJsEvent(FROM_HERE, "onTransactionStart", JsEventDetails(&details));
-}
-
namespace {
// Max number of changes we attempt to convert to values (to avoid
@@ -111,19 +98,6 @@ void JsMutationEventObserver::OnTransactionWrite(
HandleJsEvent(FROM_HERE, "onTransactionWrite", JsEventDetails(&details));
}
-void JsMutationEventObserver::OnTransactionEnd(
- const tracked_objects::Location& location,
- const syncable::WriterTag& writer) {
- DCHECK(non_thread_safe_.CalledOnValidThread());
- if (!event_handler_.IsInitialized()) {
- return;
- }
- DictionaryValue details;
- details.SetString("location", location.ToString());
- details.SetString("writer", syncable::WriterTagToString(writer));
- HandleJsEvent(FROM_HERE, "onTransactionEnd", JsEventDetails(&details));
-}
-
void JsMutationEventObserver::HandleJsEvent(
const tracked_objects::Location& from_here,
const std::string& name, const JsEventDetails& details) {
« no previous file with comments | « chrome/browser/sync/js/js_mutation_event_observer.h ('k') | chrome/browser/sync/syncable/syncable.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698