Issue 874003: Vboot Reference: Initialize local pointers with NULL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 874003: Vboot Reference: Initialize local pointers with NULL. (Closed)

Created:
10 years, 9 months ago by gauravsh

Modified:
9 years, 6 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

Vboot Reference: Initialize local pointers with NULL. I tried this with the build_autotest.sh and the test built successfully this time. Hopefully this is the end of the autotest compile errors.

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	src/platform/vboot_reference/utils/dumpRSAPublicKey.c	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

gauravsh

Submitted. I would love to hear if the test setup and build is successful this ...

10 years, 9 months ago (2010-03-12 00:32:54 UTC) #3

petkov

10 years, 9 months ago (2010-03-12 01:09:35 UTC) #4

Seems to build now. Thanks.

On Thu, Mar 11, 2010 at 4:32 PM, Gaurav Shah <gauravsh@chromium.org> wrote:

> Submitted. I would love to hear if the test setup and build is
> successful this time.  :)
>
> On Thu, Mar 11, 2010 at 4:26 PM,  <petkov@chromium.org> wrote:
> > LGTM
> >
> >
> > http://codereview.chromium.org/874003
> >
>
>
>
> --
> -g
>

Expand Messages | Collapse Messages