base::Bind fixes

base::Bind fixes


R=jhawkins@chromium.org
BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112153

[James Hawkins, 2011-11-30 01:36:08]

LGTM

[commit-bot: I haz the power, 2011-11-30 02:21:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/8735014/1

[commit-bot: I haz the power, 2011-11-30 02:21:12]

Presubmit check for 8735014-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
net/dns/serial_worker_unittest.cc,net/dns/watching_file_reader_unittest.cc

Presubmit checks took 1.4s to calculate.

[mmenke, 2011-11-30 02:29:05]

I'm a net owner, so can sign off on this.

http://codereview.chromium.org/8735014/diff/1/net/dns/watching_file_reader_un...
File net/dns/watching_file_reader_unittest.cc (right):

http://codereview.chromium.org/8735014/diff/1/net/dns/watching_file_reader_un...
net/dns/watching_file_reader_unittest.cc:115: new
base::Bind(&WatchingFileReaderTest::BreakCallback, this, b));
I'm no expert on the new callback system, but it doesn't look to me like |this|
is ref-counted.  Don't you need a base::Unretained()?

[groby-ooo-7-16, 2011-11-30 03:03:41]

http://codereview.chromium.org/8735014/diff/1/net/dns/watching_file_reader_un...
File net/dns/watching_file_reader_unittest.cc (right):

http://codereview.chromium.org/8735014/diff/1/net/dns/watching_file_reader_un...
net/dns/watching_file_reader_unittest.cc:115: new
base::Bind(&WatchingFileReaderTest::BreakCallback, this, b));
On 2011/11/30 02:29:05, Matt Menke wrote:
> I'm no expert on the new callback system, but it doesn't look to me like
|this|
> is ref-counted.  Don't you need a base::Unretained()?

You are absolutely correct, thank you for catching this!

[mmenke, 2011-11-30 03:14:23]

LGTM

[commit-bot: I haz the power, 2011-11-30 04:53:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/8735014/7001

[commit-bot: I haz the power, 2011-11-30 06:37:42]

Change committed as 112153