base::Bind fixes

net/dns/watching_file_reader_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/dns/watching_file_reader.h"
 
 #include "base/message_loop.h"
 #include "base/synchronization/lock.h"
 #include "base/synchronization/waitable_event.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 87 matching lines @@
     BreakNow("OnWatch");
     return !fail_on_watch_;
   }
 
   void OnWork() {
     EXPECT_TRUE(message_loop_ == MessageLoop::current());
     BreakNow("OnWork");
   }
 
  protected:
-  friend class BreakTask;
-  class BreakTask : public Task {
-   public:
-    BreakTask(WatchingFileReaderTest* test, std::string breakpoint)
-      : test_(test), breakpoint_(breakpoint) {}
-    virtual ~BreakTask() {}
-    virtual void Run() OVERRIDE {
-      test_->breakpoint_ = breakpoint_;
-      MessageLoop::current()->QuitNow();
-    }
-   private:
-    WatchingFileReaderTest* test_;
-    std::string breakpoint_;
-  };
+  void BreakCallback(std::string breakpoint) {
+    breakpoint_ = breakpoint;
+    MessageLoop::current()->QuitNow();
+  }
 
   void BreakNow(std::string b) {
-    message_loop_->PostTask(FROM_HERE, new BreakTask(this, b));
+    message_loop_->PostTask(FROM_HERE,
+        new base::Bind(&WatchingFileReaderTest::BreakCallback, this, b));

[mmenke, 2011/11/30 02:29:05]

I'm no expert on the new callback system, but it doesn't look to me like |this|
is ref-counted.  Don't you need a base::Unretained()?

[groby-ooo-7-16, 2011/11/30 03:03:42]

You are absolutely correct, thank you for catching this!

   }
 
   void RunUntilBreak(std::string b) {
     message_loop_->Run();
     ASSERT_EQ(breakpoint_, b);
   }
 
   WatchingFileReaderTest()
       : watcher_shim_(NULL),
         fail_on_watch_(false),
@@ skipping 31 matching lines @@
   watcher_shim_->PathChanged();
   RunUntilBreak("OnWork");
 
   message_loop_->AssertIdle();
 }
 
 }  // namespace
 
 }  // namespace net