Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 8735001: Move the comparators for QuotaInfo into the class. (Closed)

Created:
9 years ago by Reid Kleckner
Modified:
9 years ago
Reviewers:
tzik
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Move the comparators for QuotaInfo into the class. My version of MSVC 2008 has a bug in ADL that prevents it from finding the operators in the global namespace if the class in question is nested. This meant I was unable to compile the BrowsingDataQuotaHelperTest.FetchData test because it tried to use std::set<QuotaInfo>. Moving the operators into the class itself solves the problem, and should work properly with all other compilers as well. TEST=BrowsingDataQuotaHelperTest R=tzik@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112237

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -17 lines) Patch
M chrome/browser/browsing_data_quota_helper.h View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/browsing_data_quota_helper.cc View 1 chunk +12 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Reid Kleckner
PTAL
9 years ago (2011-11-29 20:56:53 UTC) #1
tzik
On 2011/11/29 20:56:53, Reid Kleckner wrote: > PTAL LGTM. Could you print your MSVC version? ...
9 years ago (2011-11-30 02:08:12 UTC) #2
Reid Kleckner
On 2011/11/30 02:08:12, tzik wrote: > On 2011/11/29 20:56:53, Reid Kleckner wrote: > > PTAL ...
9 years ago (2011-11-30 15:24:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rnk@chromium.org/8735001/1005
9 years ago (2011-11-30 15:24:57 UTC) #4
commit-bot: I haz the power
9 years ago (2011-11-30 16:31:03 UTC) #5
Change committed as 112237

Powered by Google App Engine
This is Rietveld 408576698