Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: chrome/browser/browsing_data_quota_helper.h

Issue 8735001: Move the comparators for QuotaInfo into the class. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/browsing_data_quota_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browsing_data_quota_helper.h
===================================================================
--- chrome/browser/browsing_data_quota_helper.h (revision 112007)
+++ chrome/browser/browsing_data_quota_helper.h (working copy)
@@ -47,6 +47,12 @@
int64 persistent_usage);
~QuotaInfo();
+ // Certain versions of MSVC 2008 have bad implementations of ADL for nested
+ // classes so they require these operators to be declared here instead of in
+ // the global namespace.
+ bool operator <(const QuotaInfo& rhs) const;
+ bool operator ==(const QuotaInfo& rhs) const;
+
std::string host;
int64 temporary_usage;
int64 persistent_usage;
@@ -74,9 +80,4 @@
DISALLOW_COPY_AND_ASSIGN(BrowsingDataQuotaHelper);
};
-bool operator <(const BrowsingDataQuotaHelper::QuotaInfo& lhs,
- const BrowsingDataQuotaHelper::QuotaInfo& rhs);
-bool operator ==(const BrowsingDataQuotaHelper::QuotaInfo& lhs,
- const BrowsingDataQuotaHelper::QuotaInfo& rhs);
-
#endif // CHROME_BROWSER_BROWSING_DATA_QUOTA_HELPER_H_
« no previous file with comments | « no previous file | chrome/browser/browsing_data_quota_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698