Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 8734021: Make CHECK not print messages in official builds (Closed)

Created:
9 years ago by akalin
Modified:
9 years ago
CC:
chromium-reviews, Paweł Hajdan Jr., brettw-cc_chromium.org
Visibility:
Public.

Description

Make CHECK not print messages in official builds This cuts down on the number of strings in the executable, as well as executable code to print them. On Linux, this saves 208kb on a stripped official build (chrome executable file went from 64569072 bytes -> 64782064 bytes) On OS X, this saves 209kb on an official build (Google Chrome Framework went from 51483872 bytes -> 51274984 bytes) On Windows, this saves 139kb on an official build (chrome.dll went from 28619264 bytes -> 28477440 bytes) Fix test failure in logging_unittest.cc in official builds. Add new executable check_example for easy testing of changes to the CHECK macros. BUG=101561 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112649

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -28 lines) Patch
M base/base.gyp View 1 chunk +10 lines, -0 lines 0 comments Download
A base/check_example.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M base/logging.h View 6 chunks +52 lines, -27 lines 0 comments Download
M base/logging_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
akalin
+willchan for review
9 years ago (2011-11-30 08:05:00 UTC) #1
akalin
On 2011/11/30 08:05:00, akalin wrote: > +willchan for review Ping! Updated CL description with numbers ...
9 years ago (2011-12-01 17:09:48 UTC) #2
willchan no longer on Chromium
lgtm
9 years ago (2011-12-01 22:54:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/8734021/1
9 years ago (2011-12-01 23:13:37 UTC) #4
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years ago (2011-12-02 01:43:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/8734021/1
9 years ago (2011-12-02 02:12:11 UTC) #6
commit-bot: I haz the power
Try job failure for 8734021-1 (retry) on linux_rel for step "compile" (clobber build). It's a ...
9 years ago (2011-12-02 02:47:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/8734021/1
9 years ago (2011-12-02 05:14:36 UTC) #8
commit-bot: I haz the power
9 years ago (2011-12-02 07:31:11 UTC) #9
Change committed as 112649

Powered by Google App Engine
This is Rietveld 408576698