base/logging_unittest.cc - Issue 8734021: Make CHECK not print messages in official builds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/logging_unittest.cc

Issue 8734021: Make CHECK not print messages in official builds (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/logging_unittest.cc

diff --git a/base/logging_unittest.cc b/base/logging_unittest.cc

index 08d78307f2ff3f16ad058f01818875e09033fec7..c434129d63a2ebcea3cf249ab250d8049549d5a1 100644

--- a/base/logging_unittest.cc

+++ b/base/logging_unittest.cc

@@ -210,7 +210,7 @@ TEST_F(LoggingTest, DcheckStreamsAreLazy) {

}

TEST_F(LoggingTest, Dcheck) {

-#if defined(LOGGING_IS_OFFICIAL_BUILD)

+#if LOGGING_IS_OFFICIAL_BUILD

// Official build.

EXPECT_FALSE(DCHECK_IS_ON());

EXPECT_FALSE(DLOG_IS_ON(DCHECK));

« no previous file with comments | « base/logging.h ('k') | no next file » | no next file with comments »