Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 8728038: Allow passing in a list of scopes to the access token fetcher class. (Closed)

Created:
9 years ago by Munjal (Google)
Modified:
9 years ago
Reviewers:
sail, Rick Campbell
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Allow passing in a list of scopes to the access token fetcher class. This enables full ability to dosn scope: given a login scoped refresh token, get an access token for any scope (or more accurately any list of scopes). Add tests for MakeGetAccessTokenBody (and fix a bug that the test discovered - missing &). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112158

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -23 lines) Patch
M chrome/common/net/gaia/oauth2_access_token_fetcher.h View 1 2 3 chunks +17 lines, -7 lines 0 comments Download
M chrome/common/net/gaia/oauth2_access_token_fetcher.cc View 1 2 6 chunks +38 lines, -12 lines 0 comments Download
M chrome/common/net/gaia/oauth2_access_token_fetcher_unittest.cc View 1 2 4 chunks +48 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Munjal (Google)
Sailesh, after this patch is committed, you will get an access token from this fetcher ...
9 years ago (2011-11-29 20:20:22 UTC) #1
sail
http://codereview.chromium.org/8728038/diff/1/chrome/common/net/gaia/oauth2_access_token_fetcher.cc File chrome/common/net/gaia/oauth2_access_token_fetcher.cc (right): http://codereview.chromium.org/8728038/diff/1/chrome/common/net/gaia/oauth2_access_token_fetcher.cc#newcode97 chrome/common/net/gaia/oauth2_access_token_fetcher.cc:97: source_(source), What should I pass for source? This doesn't ...
9 years ago (2011-11-29 20:43:10 UTC) #2
Munjal (Google)
http://codereview.chromium.org/8728038/diff/1/chrome/common/net/gaia/oauth2_access_token_fetcher.cc File chrome/common/net/gaia/oauth2_access_token_fetcher.cc (right): http://codereview.chromium.org/8728038/diff/1/chrome/common/net/gaia/oauth2_access_token_fetcher.cc#newcode97 chrome/common/net/gaia/oauth2_access_token_fetcher.cc:97: source_(source), On 2011/11/29 20:43:11, sail wrote: > What should ...
9 years ago (2011-11-29 21:58:09 UTC) #3
sail
9 years ago (2011-11-29 22:57:18 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698