Allow passing in a list of scopes to the access token fetcher class.

chrome/common/net/gaia/oauth2_access_token_fetcher_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // A complete set of unit tests for OAuth2AccessTokenFetcher.
 
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
@@ skipping 17 matching lines @@
 using content::BrowserThread;
 using content::URLFetcher;
 using content::URLFetcherDelegate;
 using content::URLFetcherFactory;
 using net::ResponseCookies;
 using net::URLRequestStatus;
 using testing::_;
 using testing::Return;
 
 namespace {
+typedef std::vector<std::string> ScopeList;
+
 static const char kValidTokenResponse[] =
     "{"
     "  \"access_token\": \"at1\","
     "  \"expires_in\": 3600,"
     "  \"token_type\": \"Bearer\""
     "}";
 static const char kTokenResponseNoAccessToken[] =
     "{"
     "  \"expires_in\": 3600,"
     "  \"token_type\": \"Bearer\""
@@ skipping 23 matching lines @@
 
   MOCK_METHOD1(OnGetTokenSuccess, void(const std::string& access_token));
   MOCK_METHOD1(OnGetTokenFailure,
                void(const GoogleServiceAuthError& error));
 };
 
 class OAuth2AccessTokenFetcherTest : public testing::Test {
  public:
   OAuth2AccessTokenFetcherTest()
     : ui_thread_(BrowserThread::UI, &message_loop_),
-      fetcher_(&consumer_, profile_.GetRequestContext(), "test") {
+      fetcher_(&consumer_, profile_.GetRequestContext()) {
   }
 
   virtual ~OAuth2AccessTokenFetcherTest() { }
 
   virtual TestURLFetcher* SetupGetAccessToken(
       bool fetch_succeeds, int response_code, const std::string& body) {
     GURL url(GaiaUrls::GetInstance()->oauth2_token_url());
     TestURLFetcher* url_fetcher = new TestURLFetcher(0, url, &fetcher_);
     URLRequestStatus::Status status =
         fetch_succeeds ? URLRequestStatus::SUCCESS : URLRequestStatus::FAILED;
@@ skipping 15 matching lines @@
   content::TestBrowserThread ui_thread_;
   MockUrlFetcherFactory factory_;
   MockOAuth2AccessTokenConsumer consumer_;
   TestingProfile profile_;
   OAuth2AccessTokenFetcher fetcher_;
 };
 
 TEST_F(OAuth2AccessTokenFetcherTest, GetAccessTokenRequestFailure) {
   TestURLFetcher* url_fetcher = SetupGetAccessToken(false, 0, "");
   EXPECT_CALL(consumer_, OnGetTokenFailure(_)).Times(1);
-  fetcher_.Start("client_id", "client_secret", "refresh_token");
+  fetcher_.Start("client_id", "client_secret", "refresh_token", ScopeList());
   fetcher_.OnURLFetchComplete(url_fetcher);
 }
 
 TEST_F(OAuth2AccessTokenFetcherTest, GetAccessTokenResponseCodeFailure) {
   TestURLFetcher* url_fetcher = SetupGetAccessToken(true, RC_FORBIDDEN, "");
   EXPECT_CALL(consumer_, OnGetTokenFailure(_)).Times(1);
-  fetcher_.Start("client_id", "client_secret", "refresh_token");
+  fetcher_.Start("client_id", "client_secret", "refresh_token", ScopeList());
   fetcher_.OnURLFetchComplete(url_fetcher);
 }
 
 TEST_F(OAuth2AccessTokenFetcherTest, Success) {
   TestURLFetcher* url_fetcher = SetupGetAccessToken(
       true, RC_REQUEST_OK, kValidTokenResponse);
   EXPECT_CALL(consumer_, OnGetTokenSuccess("at1")).Times(1);
-  fetcher_.Start("client_id", "client_secret", "refresh_token");
+  fetcher_.Start("client_id", "client_secret", "refresh_token", ScopeList());
   fetcher_.OnURLFetchComplete(url_fetcher);
 }
 
+TEST_F(OAuth2AccessTokenFetcherTest, MakeGetAccessTokenBody) {
+  {  // No scope.
+    std::string body =
+        "client_id=cid1&"
+        "client_secret=cs1&"
+        "grant_type=refresh_token&"
+        "refresh_token=rt1";
+    EXPECT_EQ(body, OAuth2AccessTokenFetcher::MakeGetAccessTokenBody(
+        "cid1", "cs1", "rt1", ScopeList()));
+  }
+
+  {  // One scope.
+    std::string body =
+        "client_id=cid1&"
+        "client_secret=cs1&"
+        "grant_type=refresh_token&"
+        "refresh_token=rt1&"
+        "scope=https://www.googleapis.com/foo";
+    ScopeList scopes;
+    scopes.push_back("https://www.googleapis.com/foo");
+    EXPECT_EQ(body, OAuth2AccessTokenFetcher::MakeGetAccessTokenBody(
+        "cid1", "cs1", "rt1", scopes));
+  }
+
+  {  // Multiple scopes.
+    std::string body =
+        "client_id=cid1&"
+        "client_secret=cs1&"
+        "grant_type=refresh_token&"
+        "refresh_token=rt1&"
+        "scope=https://www.googleapis.com/foo,"
+        "https://www.googleapis.com/bar,"
+        "https://www.googleapis.com/baz";
+    ScopeList scopes;
+    scopes.push_back("https://www.googleapis.com/foo");
+    scopes.push_back("https://www.googleapis.com/bar");
+    scopes.push_back("https://www.googleapis.com/baz");
+    EXPECT_EQ(body, OAuth2AccessTokenFetcher::MakeGetAccessTokenBody(
+        "cid1", "cs1", "rt1", scopes));
+  }
+}
+
 TEST_F(OAuth2AccessTokenFetcherTest, ParseGetAccessTokenResponse) {
   {  // No body.
     TestURLFetcher url_fetcher(0, GURL("www.google.com"), NULL);
 
     std::string at;
     EXPECT_FALSE(OAuth2AccessTokenFetcher::ParseGetAccessTokenResponse(
         &url_fetcher, &at));
     EXPECT_TRUE(at.empty());
   }
   {  // Bad json.
@@ skipping 17 matching lines @@
   {  // Valid json: all good.
     TestURLFetcher url_fetcher(0, GURL("www.google.com"), NULL);
     url_fetcher.SetResponseString(kValidTokenResponse);
 
     std::string at;
     EXPECT_TRUE(OAuth2AccessTokenFetcher::ParseGetAccessTokenResponse(
         &url_fetcher, &at));
     EXPECT_EQ("at1", at);
   }
 }