chrome/browser/prefs/pref_value_map.h - Issue 8727037: Signed settings refactoring: Proper caching and more tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prefs/pref_value_map.h

Issue 8727037: Signed settings refactoring: Proper caching and more tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed second round of comments and fixed a mem leak in one of the new tests. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/prefs/pref_value_map.h

diff --git a/chrome/browser/prefs/pref_value_map.h b/chrome/browser/prefs/pref_value_map.h

index f8995ce386fe9af6003cafb44942dc234154a488..291c7b42a9bdf1ce4f05393d7a1254785eefc563 100644

--- a/chrome/browser/prefs/pref_value_map.h

+++ b/chrome/browser/prefs/pref_value_map.h

@@ -51,6 +51,9 @@ class PrefValueMap {

// the value was found and of the proper type.

bool GetBoolean(const std::string& key, bool* value) const;

+ // Sets the value for |key| to the boolean |value|.

+ void SetBoolean(const std::string& key, bool value);

// Gets a string value for |key| and stores it in |value|. Returns true if

// the value was found and of the proper type.

bool GetString(const std::string& key, std::string* value) const;