chrome/browser/prefs/pref_value_map.cc - Issue 8727037: Signed settings refactoring: Proper caching and more tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prefs/pref_value_map.cc

Issue 8727037: Signed settings refactoring: Proper caching and more tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed second round of comments and fixed a mem leak in one of the new tests. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/prefs/pref_value_map.cc

diff --git a/chrome/browser/prefs/pref_value_map.cc b/chrome/browser/prefs/pref_value_map.cc

index 3d69cf160dee72610500222f04c591b6d7ee8808..7e876f91528e3f1cf8817b9aeb7776d75a1a98cf 100644

--- a/chrome/browser/prefs/pref_value_map.cc

+++ b/chrome/browser/prefs/pref_value_map.cc

@@ -91,6 +91,10 @@ bool PrefValueMap::GetBoolean(const std::string& key,

return GetValue(key, &stored_value) && stored_value->GetAsBoolean(value);

}

+void PrefValueMap::SetBoolean(const std::string& key, bool value) {

+ SetValue(key, Value::CreateBooleanValue(value));

bool PrefValueMap::GetString(const std::string& key,

std::string* value) const {

const Value* stored_value = NULL;