Signed settings refactoring: Proper caching and more tests.

chrome/browser/prefs/pref_value_map.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/prefs/pref_value_map.h"
 
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/stl_util.h"
 #include "base/values.h"
@@ skipping 73 matching lines @@
 PrefValueMap::const_iterator PrefValueMap::end() const {
   return prefs_.end();
 }
 
 bool PrefValueMap::GetBoolean(const std::string& key,
                               bool* value) const {
   const Value* stored_value = NULL;
   return GetValue(key, &stored_value) && stored_value->GetAsBoolean(value);
 }
 
+void PrefValueMap::SetBoolean(const std::string& key, bool value) {
+  SetValue(key, Value::CreateBooleanValue(value));
+}
+
 bool PrefValueMap::GetString(const std::string& key,
                              std::string* value) const {
   const Value* stored_value = NULL;
   return GetValue(key, &stored_value) && stored_value->GetAsString(value);
 }
 
 void PrefValueMap::SetString(const std::string& key,
                              const std::string& value) {
   SetValue(key, Value::CreateStringValue(value));
 }
@@ skipping 30 matching lines @@
       ++other_pref;
     }
   }
 
   // Add the remaining entries.
   for ( ; this_pref != prefs_.end(); ++this_pref)
       differing_keys->push_back(this_pref->first);
   for ( ; other_pref != other->prefs_.end(); ++other_pref)
       differing_keys->push_back(other_pref->first);
 }