Issue 8726023: Remove ChildThread dependency from Chrome. In the future we might want to expose it as an interfa...

Issue 8726023: Remove ChildThread dependency from Chrome. In the future we might want to expose it as an interfa... (Closed)

Created:
9 years ago by jam

Modified:
9 years ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, tfarina

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove ChildThread dependency from Chrome. In the future we might want to expose it as an interface, but for now that's not required. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111951

Patch Set 1 #

Total comments: 2

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -10 lines)			Patch
M	chrome/browser/importer/external_process_importer_bridge.h	View	3 chunks	+6 lines, -6 lines	2 comments	Download
M	chrome/browser/importer/external_process_importer_bridge.cc	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/utility/chrome_content_utility_client.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

lgtm w/ the following nit / question. http://codereview.chromium.org/8726023/diff/1/chrome/browser/importer/external_process_importer_bridge.h File chrome/browser/importer/external_process_importer_bridge.h (right): http://codereview.chromium.org/8726023/diff/1/chrome/browser/importer/external_process_importer_bridge.h#newcode16 chrome/browser/importer/external_process_importer_bridge.h:16: #include "ipc/ipc_message.h" ...

9 years ago (2011-11-29 01:27:24 UTC) #2

jam

http://codereview.chromium.org/8726023/diff/1/chrome/browser/importer/external_process_importer_bridge.h File chrome/browser/importer/external_process_importer_bridge.h (right): http://codereview.chromium.org/8726023/diff/1/chrome/browser/importer/external_process_importer_bridge.h#newcode16 chrome/browser/importer/external_process_importer_bridge.h:16: #include "ipc/ipc_message.h" On 2011/11/29 01:27:24, Dirk Pranke wrote: > ...

9 years ago (2011-11-29 01:46:12 UTC) #3

Dirk Pranke

9 years ago (2011-11-29 01:55:30 UTC) #4

On Mon, Nov 28, 2011 at 5:46 PM,  <jam@chromium.org> wrote:
>
>
http://codereview.chromium.org/8726023/diff/1/chrome/browser/importer/externa...
> File chrome/browser/importer/external_process_importer_bridge.h (right):
>
>
http://codereview.chromium.org/8726023/diff/1/chrome/browser/importer/externa...
> chrome/browser/importer/external_process_importer_bridge.h:16: #include
> "ipc/ipc_message.h"
> On 2011/11/29 01:27:24, Dirk Pranke wrote:
>>
>> Can't you forward-declare IPC::Message:;Sender here, and only #include
>> ipc_message in the .cc file?
>
> unfortunately we can't forward declare it because it's an inner class.
> another reason why we shouldn't have inner classes :)
> http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Nested_Classes
>

Ah, right. Thanks!

-- Dirk

> http://codereview.chromium.org/8726023/
>

Expand Messages | Collapse Messages