Remove ChildThread dependency from Chrome. In the future we might want to expose it as an interfa...

chrome/browser/importer/external_process_importer_bridge.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_IMPORTER_EXTERNAL_PROCESS_IMPORTER_BRIDGE_H_
 #define CHROME_BROWSER_IMPORTER_EXTERNAL_PROCESS_IMPORTER_BRIDGE_H_
 #pragma once
 
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/importer/importer_bridge.h"
 #include "chrome/browser/importer/profile_writer.h"
+#include "ipc/ipc_message.h"

[Dirk Pranke, 2011/11/29 01:27:24]

Can't you forward-declare IPC::Message:;Sender here, and only #include
ipc_message in the .cc file?

[jam, 2011/11/29 01:46:13]

unfortunately we can't forward declare it because it's an inner class. another
reason why we shouldn't have inner classes :)
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Nested_Classes

 
 class GURL;
 
-namespace IPC {
-class Message;
-}
-
 namespace base {
 class DictionaryValue;
 }
 
 // When the importer is run in an external process, the bridge is effectively
 // split in half by the IPC infrastructure.  The external bridge receives data
 // and notifications from the importer, and sends it across IPC.  The
 // internal bridge gathers the data from the IPC host and writes it to the
 // profile.
 class ExternalProcessImporterBridge : public ImporterBridge {
  public:
-  explicit ExternalProcessImporterBridge(
-      const base::DictionaryValue& localized_strings);
+  ExternalProcessImporterBridge(
+      const base::DictionaryValue& localized_strings,
+      IPC::Message::Sender* sender);
 
   // Begin ImporterBridge implementation:
   virtual void AddBookmarks(
       const std::vector<ProfileWriter::BookmarkEntry>& bookmarks,
       const string16& first_folder_name) OVERRIDE;
 
   virtual void AddHomePage(const GURL& home_page) OVERRIDE;
 
 #if defined(OS_WIN)
   virtual void AddIE7PasswordInfo(
@@ skipping 22 matching lines @@
 
  private:
   virtual ~ExternalProcessImporterBridge();
 
   bool Send(IPC::Message* message);
 
   // Holds strings needed by the external importer because the resource
   // bundle isn't available to the external process.
   scoped_ptr<base::DictionaryValue> localized_strings_;
 
+  IPC::Message::Sender* sender_;
+
   DISALLOW_COPY_AND_ASSIGN(ExternalProcessImporterBridge);
 };
 
 #endif  // CHROME_BROWSER_IMPORTER_EXTERNAL_PROCESS_IMPORTER_BRIDGE_H_