Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: media/base/media_android.cc

Issue 8718014: Upstream: Media implementation for Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/media_android.cc
diff --git a/media/base/media_android.cc b/media/base/media_android.cc
new file mode 100644
index 0000000000000000000000000000000000000000..a216a77e427d01962fb38b222907a08acdd1d8f5
--- /dev/null
+++ b/media/base/media_android.cc
@@ -0,0 +1,27 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
John Grabowski 2011/11/29 19:43:31 Add file-level comments explaining what this is fo
+#include "media/base/media.h"
+#include "base/logging.h"
+
+namespace media {
+
+bool InitializeMediaLibrary(const FilePath& module_dir) {
+ // Android doesn't use ffmpeg. Return true to make chrome happy
John Grabowski 2011/11/29 19:43:31 Complete sentences end in a period. Be clear that
scherkus (not reviewing) 2011/11/29 20:00:28 nit: I'd reword this as "Android doesn't require a
michaelbai 2011/11/30 17:20:34 Done.
+ return true;
+}
+
+void InitializeMediaLibraryForTesting() {
scherkus (not reviewing) 2011/11/29 20:00:28 nit: collapse empty methods to {}
+}
+
+bool IsMediaLibraryInitialized() {
+ return true;
+}
+
+bool InitializeOpenMaxLibrary(const FilePath& module_dir) {
+ NOTIMPLEMENTED();
+ return false;
+}
+
+} // namespace media

Powered by Google App Engine
This is Rietveld 408576698