Upstream: Media implementation for Android.

media/base/media_android.cc

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+

[John Grabowski, 2011/11/29 19:43:31]

Add file-level comments explaining what this is for.

+#include "media/base/media.h"
+#include "base/logging.h"
+
+namespace media {
+
+bool InitializeMediaLibrary(const FilePath& module_dir) {
+  // Android doesn't use ffmpeg. Return true to make chrome happy

[John Grabowski, 2011/11/29 19:43:31]

Complete sentences end in a period.
Be clear that "happy" is "good".  E.g. 

// Android doesn't use ffmpeg so we have nothing to do.

[scherkus (not reviewing), 2011/11/29 20:00:28]

nit: I'd reword this as "Android doesn't require any additional media
libraries."

[michaelbai, 2011/11/30 17:20:34]

Done.

+  return true;
+}
+
+void InitializeMediaLibraryForTesting() {

[scherkus (not reviewing), 2011/11/29 20:00:28]

nit: collapse empty methods to {}

+}
+
+bool IsMediaLibraryInitialized() {
+  return true;
+}
+
+bool InitializeOpenMaxLibrary(const FilePath& module_dir) {
+  NOTIMPLEMENTED();
+  return false;
+}
+
+}  // namespace media