Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1254)

Unified Diff: media/audio/android/audio_manager_android.cc

Issue 8718014: Upstream: Media implementation for Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/android/audio_manager_android.cc
diff --git a/media/audio/android/audio_manager_android.cc b/media/audio/android/audio_manager_android.cc
new file mode 100644
index 0000000000000000000000000000000000000000..c82f94c33403b9c396b58e19a7dc4ff89a977c37
--- /dev/null
+++ b/media/audio/android/audio_manager_android.cc
@@ -0,0 +1,63 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "media/audio/android/audio_manager_android.h"
+
+#include "base/logging.h"
+#include "media/audio/android/audio_track_output_android.h"
+#include "media/audio/audio_manager.h"
+#include "media/audio/fake_audio_input_stream.h"
+#include "media/audio/fake_audio_output_stream.h"
+
+void AudioManagerAndroid::Init() {
+ AudioManagerBase::Init();
+}
+
+bool AudioManagerAndroid::HasAudioOutputDevices() {
+ return true;
+}
+
+bool AudioManagerAndroid::HasAudioInputDevices() {
+ return false;
+}
+
+AudioOutputStream* AudioManagerAndroid::MakeAudioOutputStream(
+ const AudioParameters& params) {
+ if (!params.IsValid())
+ return NULL;
+
+ if (params.format == AudioParameters::AUDIO_MOCK) {
+ return FakeAudioOutputStream::MakeFakeStream(params);
+ } else if (params.format == AudioParameters::AUDIO_PCM_LINEAR ||
scherkus (not reviewing) 2011/11/29 20:00:28 nit: no need for else
michaelbai 2011/11/30 17:20:34 Done.
+ params.format == AudioParameters::AUDIO_PCM_LOW_LATENCY) {
+ return AudioTrackOutputStream::MakeStream(this, params);
+ }
+
+ return NULL;
+}
+
+AudioInputStream* AudioManagerAndroid::MakeAudioInputStream(
+ const AudioParameters& params) {
+ return FakeAudioInputStream::MakeFakeStream(params);
+}
+
+void AudioManagerAndroid::MuteAll() {
+ NOTIMPLEMENTED();
+}
+
+void AudioManagerAndroid::UnMuteAll() {
+ NOTIMPLEMENTED();
+}
+
+AudioManagerAndroid::AudioManagerAndroid() {
scherkus (not reviewing) 2011/11/29 20:00:28 nit: collapse empty methods that fit onto one line
michaelbai 2011/11/30 17:20:34 Done.
+}
+
+AudioManagerAndroid::~AudioManagerAndroid() {
scherkus (not reviewing) 2011/11/29 20:00:28 nit: try to match function ordering inside of .h w
michaelbai 2011/11/30 17:20:34 Done.
+ audio_thread_.Stop();
+}
+
+//static
scherkus (not reviewing) 2011/11/29 20:00:28 nit: one period between // and static also we typ
michaelbai 2011/11/30 17:20:34 Done.
+AudioManager* AudioManager::CreateAudioManager() {
+ return new AudioManagerAndroid();
+}

Powered by Google App Engine
This is Rietveld 408576698