Upstream: Media implementation for Android.

media/audio/android/audio_manager_android.cc

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "media/audio/android/audio_manager_android.h"
+
+#include "base/logging.h"
+#include "media/audio/android/audio_track_output_android.h"
+#include "media/audio/audio_manager.h"
+#include "media/audio/fake_audio_input_stream.h"
+#include "media/audio/fake_audio_output_stream.h"
+
+void AudioManagerAndroid::Init() {
+  AudioManagerBase::Init();
+}
+
+bool AudioManagerAndroid::HasAudioOutputDevices() {
+  return true;
+}
+
+bool AudioManagerAndroid::HasAudioInputDevices() {
+  return false;
+}
+
+AudioOutputStream* AudioManagerAndroid::MakeAudioOutputStream(
+    const AudioParameters& params) {
+  if (!params.IsValid())
+    return NULL;
+
+  if (params.format == AudioParameters::AUDIO_MOCK) {
+    return FakeAudioOutputStream::MakeFakeStream(params);
+  } else if (params.format == AudioParameters::AUDIO_PCM_LINEAR ||

[scherkus (not reviewing), 2011/11/29 20:00:28]

nit: no need for else

[michaelbai, 2011/11/30 17:20:34]

Done.

+             params.format == AudioParameters::AUDIO_PCM_LOW_LATENCY) {
+    return AudioTrackOutputStream::MakeStream(this, params);
+  }
+
+  return NULL;
+}
+
+AudioInputStream* AudioManagerAndroid::MakeAudioInputStream(
+    const AudioParameters& params) {
+  return FakeAudioInputStream::MakeFakeStream(params);
+}
+
+void AudioManagerAndroid::MuteAll() {
+  NOTIMPLEMENTED();
+}
+
+void AudioManagerAndroid::UnMuteAll() {
+  NOTIMPLEMENTED();
+}
+
+AudioManagerAndroid::AudioManagerAndroid() {

[scherkus (not reviewing), 2011/11/29 20:00:28]

nit: collapse empty methods that fit onto one line w/ {}

[michaelbai, 2011/11/30 17:20:34]

Done.

+}
+
+AudioManagerAndroid::~AudioManagerAndroid() {

[scherkus (not reviewing), 2011/11/29 20:00:28]

nit: try to match function ordering inside of .h where it makes sense

in this case we generally put ctor/dtor at top

[michaelbai, 2011/11/30 17:20:34]

Done.

+  audio_thread_.Stop();
+}
+
+//static

[scherkus (not reviewing), 2011/11/29 20:00:28]

nit: one period between // and static

also we typically put statics at the top of the file before ctor/dtor

[michaelbai, 2011/11/30 17:20:34]

Done.

+AudioManager* AudioManager::CreateAudioManager() {
+  return new AudioManagerAndroid();
+}