Move use_skia_on_mac setting into its own gypi file, so that WebKit scripts can

Move use_skia_on_mac setting into its own gypi file, so that WebKit scripts can
change their behavior based on its setting.

This will help keep buildbots green during a transition period (see bug).

BUG=101731
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111734

[epoger, 2011-11-28 16:16:30]

Mike- I think this should be a clean way to put the "are Chromium Mac builds
using Skia" information in an isolated place where the WebKit scripts can use
it.  If it seems reasonable to you and passes trybots, I'll send it to a
gyp-knowledgable person for review.

[epoger, 2011-11-28 18:18:03]

See webkit patch at https://bugs.webkit.org/show_bug.cgi?id=73226 that will use
this CL to automatically change the comparison baselines between CG and Skia.

(Note that this CL does not actually change the use_skia value in any case. 
That change will come later.)

The trybot results look good... the compiles are all green.  The redness I have
seen so far doesn't have anything to do with this change.

[M-A Ruel, 2011-11-28 18:44:02]

http://codereview.chromium.org/8716011/diff/1/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/8716011/diff/1/build/common.gypi#newcode20
build/common.gypi:20: 'includes': [
I didn't realize you could include inside variables.

http://codereview.chromium.org/8716011/diff/1/build/use_skia_on_mac.gypi
File build/use_skia_on_mac.gypi (right):

http://codereview.chromium.org/8716011/diff/1/build/use_skia_on_mac.gypi#newc...
build/use_skia_on_mac.gypi:1: # Whether the Mac port uses Skia (instead of Core
Graphics) by default.
Add copyright

http://codereview.chromium.org/8716011/diff/1/build/use_skia_on_mac.gypi#newc...
build/use_skia_on_mac.gypi:6: 
remove extra line

[epoger, 2011-11-28 18:52:26]

http://codereview.chromium.org/8716011/diff/1/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/8716011/diff/1/build/common.gypi#newcode20
build/common.gypi:20: 'includes': [
On 2011/11/28 18:44:03, Marc-Antoine Ruel wrote:
> I didn't realize you could include inside variables.

I didn't either.  gyp is still a black art to me... all I know is, I tried it
and it works.

http://codereview.chromium.org/8716011/diff/1/build/use_skia_on_mac.gypi
File build/use_skia_on_mac.gypi (right):

http://codereview.chromium.org/8716011/diff/1/build/use_skia_on_mac.gypi#newc...
build/use_skia_on_mac.gypi:1: # Whether the Mac port uses Skia (instead of Core
Graphics) by default.
On 2011/11/28 18:44:03, Marc-Antoine Ruel wrote:
> Add copyright

Done.

http://codereview.chromium.org/8716011/diff/1/build/use_skia_on_mac.gypi#newc...
build/use_skia_on_mac.gypi:6: 
On 2011/11/28 18:44:03, Marc-Antoine Ruel wrote:
> remove extra line

Done.

[M-A Ruel, 2011-11-28 18:53:25]

lgtm