Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: build/common.gypi

Issue 8716011: Move use_skia_on_mac setting into its own gypi file, so that WebKit scripts can (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/use_skia_on_mac.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
===================================================================
--- build/common.gypi (revision 111729)
+++ build/common.gypi (working copy)
@@ -17,6 +17,9 @@
# we need to have 'chromeos' already set).
'variables': {
'variables': {
+ 'includes': [
+ 'use_skia_on_mac.gypi',
+ ],
'variables': {
# Whether we're building a ChromeOS build.
'chromeos%': 0,
@@ -35,6 +38,10 @@
# Disable Virtual keyboard support by default.
'use_virtual_keyboard%': 0,
+
+ # Default setting for use_skia on mac platform.
+ # This is typically overridden in use_skia_on_mac.gypi.
+ 'use_skia_on_mac%': 0,
},
# Copy conditionally-set variables out one scope.
'chromeos%': '<(chromeos)',
@@ -42,6 +49,7 @@
'use_aura%': '<(use_aura)',
'use_openssl%': '<(use_openssl)',
'use_virtual_keyboard%': '<(use_virtual_keyboard)',
+ 'use_skia_on_mac%': '<(use_skia_on_mac)',
# WebKit compositor for ui
'use_webkit_compositor%': 0,
@@ -81,6 +89,7 @@
'use_aura%': '<(use_aura)',
'use_openssl%': '<(use_openssl)',
'use_virtual_keyboard%': '<(use_virtual_keyboard)',
+ 'use_skia_on_mac%': '<(use_skia_on_mac)',
# The variable touchui is still present (until all clean up is done).
'touchui%': 0,
@@ -235,7 +244,7 @@
# the 'conditions' clause. Initial attempts resulted in chromium and
# webkit disagreeing on its setting.
['OS=="mac"', {
- 'use_skia%': 0,
+ 'use_skia%': '<(use_skia_on_mac)',
# Mac uses clang by default, so turn on the plugin as well.
'clang_use_chrome_plugins%': 1,
}, {
@@ -366,6 +375,7 @@
'chromeos%': '<(chromeos)',
'touchui%': '<(touchui)',
'use_virtual_keyboard%': '<(use_virtual_keyboard)',
+ 'use_skia_on_mac%': '<(use_skia_on_mac)',
'use_xi2_mt%':'<(use_xi2_mt)',
'file_manager_extension%': '<(file_manager_extension)',
'webui_task_manager%': '<(webui_task_manager)',
« no previous file with comments | « no previous file | build/use_skia_on_mac.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698