Issue 8702003: ASan Mac + cleanup:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8702003: ASan Mac + cleanup: (Closed)

Created:
9 years ago by Alexander Potapenko

Modified:
9 years ago

Reviewers:
Hironori Bono

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

ASan Mac + cleanup: -- move the compiler/linker options turned on by asan==1 to the conditions section to use them for host binaries too; -- use 'defines' instead of -D on Linux -- removed an obsolete comment Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111583

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -28 lines)			Patch
	M	build/common.gypi	View		3 chunks	+31 lines, -28 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

LGTM

Regards,

Hironori Bono

Expand Messages | Collapse Messages