Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6760)

Unified Diff: build/common.gypi

Issue 8702003: ASan Mac + cleanup: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
===================================================================
--- build/common.gypi (revision 111575)
+++ build/common.gypi (working copy)
@@ -1921,20 +1921,20 @@
],
}],
['asan==1', {
- # Only in the linux section for now, since ASAN doesn't
- # work on Mac yet.
# TODO(glider): -fasan is deprecated. Remove it when we stop using
# it.
'cflags': [
'-fasan',
'-faddress-sanitizer',
'-w',
- '-DADDRESS_SANITIZER',
],
'ldflags': [
'-fasan',
'-faddress-sanitizer',
],
+ 'defines': [
+ 'ADDRESS_SANITIZER',
+ ],
}],
['no_strict_aliasing==1', {
'cflags': [
@@ -2278,6 +2278,34 @@
'clang_dir': '../third_party/llvm-build/Release+Asserts/bin',
},
}],
+ ['asan==1', {
+ 'xcode_settings': {
+ 'OTHER_CFLAGS': [
+ '-fasan',
+ '-faddress-sanitizer',
+ '-w',
+ ],
+ 'OTHER_LDFLAGS': [
+ '-fasan',
+ '-faddress-sanitizer',
+ # The symbols below are referenced in the ASan runtime
+ # library (compiled on OS X 10.6), but may be unavailable
+ # on the prior OS X versions. Because Chromium is currently
+ # targeting 10.5.0, we need to explicitly mark these
+ # symbols as dynamic_lookup.
+ '-Wl,-U,_malloc_default_purgeable_zone',
+ '-Wl,-U,_malloc_zone_memalign',
+ '-Wl,-U,_dispatch_sync_f',
+ '-Wl,-U,_dispatch_async_f',
+ '-Wl,-U,_dispatch_barrier_async_f',
+ '-Wl,-U,_dispatch_group_async_f',
+ '-Wl,-U,_dispatch_after_f',
+ ],
+ },
+ 'defines': [
+ 'ADDRESS_SANITIZER',
+ ],
+ }],
],
'target_conditions': [
['_type!="static_library"', {
@@ -2328,32 +2356,7 @@
},
'xcode_settings': {
'CHROMIUM_STRIP_SAVE_FILE': '<(asan_saves_file)',
- 'OTHER_CFLAGS': [
- '-fasan',
- '-faddress-sanitizer',
- '-w',
- ],
- 'OTHER_LDFLAGS': [
- '-fasan',
- '-faddress-sanitizer',
- # The symbols below are referenced in the ASan runtime
- # library (compiled on OS X 10.6), but may be unavailable
- # on the prior OS X versions. Because Chromium is currently
- # targeting 10.5.0, we need to explicitly mark these
- # symbols as dynamic_lookup.
- '-Wl,-U,_malloc_default_purgeable_zone',
- '-Wl,-U,_malloc_zone_memalign',
- '-Wl,-U,_dispatch_sync_f',
- '-Wl,-U,_dispatch_async_f',
- '-Wl,-U,_dispatch_barrier_async_f',
- '-Wl,-U,_dispatch_group_async_f',
- '-Wl,-U,_dispatch_after_f',
-
- ],
},
- 'defines': [
- 'ADDRESS_SANITIZER',
- ],
}],
],
'target_conditions': [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698