Issue 87016: Eliminate a circular dependency by making BGRAToRGBA() generic...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 87016: Eliminate a circular dependency by making BGRAToRGBA() generic... (Closed)

Created:
11 years, 8 months ago by sgk

Modified:
9 years, 5 months ago

Reviewers:
Dean McNamee, Elliot Glaysher, Evan Stade

CC:
chromium-reviews_googlegroups.com, Mark Mentovai

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Eliminate a circular dependency by making BGRAToRGBA() generic (no pulling in guchar from gtk.h) and moving it from base/gfx to base. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14117

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -30 lines)			Patch
M	base/base.gyp	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	base/clipboard_linux.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	base/gfx/gtk_util.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	base/gfx/gtk_util.cc	View		1 chunk	+0 lines, -20 lines	0 comments	Download
A	base/linux_util.h	View		1 chunk	+19 lines, -0 lines	0 comments	Download
A	base/linux_util.cc	View		1 chunk	+31 lines, -0 lines	0 comments	Download
M	chrome/common/gtk_util.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dean McNamee

11 years, 8 months ago (2009-04-22 11:40:52 UTC) #4

On 2009/04/21 17:07:30, Evan Stade wrote:
> lg, thanks for doing this

I am missing what the circular dependency is.  What's the difference between
base/ and base/gfx/ ?

Expand Messages | Collapse Messages