Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 87014: .gyp file for Breakpad on OS X. (Closed)

Created:
11 years, 8 months ago by jeremy
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com, nealsid
Visibility:
Public.

Description

.gyp file for Breakpad on OS X.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix John's comments + obj-c side. #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -61 lines) Patch
A breakpad/breakpad.gyp View 1 1 chunk +96 lines, -0 lines 5 comments Download
M chrome/app/breakpad_mac.mm View 6 chunks +7 lines, -57 lines 0 comments Download
M chrome/chrome.gyp View 1 2 chunks +5 lines, -4 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
jeremy
Please disregard DEPS changes. This requires http://codereview.chromium.org/87013 to work + rolling breakpad to ToT. Mark: ...
11 years, 8 months ago (2009-04-20 23:40:12 UTC) #1
John Grabowski
LGTM but wait for mark http://codereview.chromium.org/87014/diff/1/3 File breakpad/breakpad.gyp (right): http://codereview.chromium.org/87014/diff/1/3#newcode1 Line 1: # Copyright (c) ...
11 years, 8 months ago (2009-04-20 23:48:55 UTC) #2
Mark Mentovai
11 years, 8 months ago (2009-04-21 00:42:12 UTC) #3
Mostly lg

http://codereview.chromium.org/87014/diff/1004/9
File breakpad/breakpad.gyp (right):

http://codereview.chromium.org/87014/diff/1004/9#newcode18
Line 18: 'target_name': 'breakpadUtilities',
This would be a first for interCapping within our target names.  Please use
breakpad_utilities instead.  Obviously you'll also need to change the
"dependencies" sections too.

http://codereview.chromium.org/87014/diff/1004/9#newcode46
Line 46: 'OTHER_LDFLAGS': ['-lcrypto',],
Use this instead:

'link_settings': {'libraries': ['$(SDKROOT)/usr/lib/libcrypto.dylib']}

http://codereview.chromium.org/87014/diff/1004/9#newcode48
Line 48: 'libraries': [
'libraries' should appear within a 'link_settings' section. 
http://code.google.com/p/gyp/wiki/InputFormatReference has some information on
link_settings.

http://codereview.chromium.org/87014/diff/1004/9#newcode72
Line 72: 'OTHER_LDFLAGS': ['-lcrypto',],
Again, remove.

http://codereview.chromium.org/87014/diff/1004/9#newcode74
Line 74: 'libraries': [
Put in link_settings as above.

http://codereview.chromium.org/87014/diff/1004/11
File chrome/chrome.gyp (right):

http://codereview.chromium.org/87014/diff/1004/11#newcode1661
Line 1661: # Needed for breakpad.
Nope, take this out.  If you get link_settings right, this isn't needed. 
Dependency targets (like breakpad in this case) should carry their own
information about libs they need, you shouldn't have to put stuff like this all
over the place just because you've added a dependency.

Powered by Google App Engine
This is Rietveld 408576698