Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 87013: Make breakpad compile against 10.5 SDK (Closed)

Created:
11 years, 8 months ago by jeremy
Modified:
5 years, 1 month ago
Reviewers:
nealsid
CC:
chromium-reviews_googlegroups.com, google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

Add paranoid logging to reporter and inspector I keep needing to add this manually every time I need to debug breakpad, better to just have it in the main source.

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -6 lines) Patch
M client/mac/crash_generation/Inspector.mm View 5 chunks +22 lines, -3 lines 0 comments Download
M client/mac/sender/crash_report_sender.h View 1 chunk +6 lines, -0 lines 0 comments Download
M client/mac/sender/crash_report_sender.m View 3 5 chunks +37 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jeremy
11 years, 8 months ago (2009-04-20 23:24:32 UTC) #1
nealsid
+google-breakpad-dev@googlegroups.com LGTM with minor nits http://codereview.chromium.org/87013/diff/1/3 File client/mac/handler/minidump_generator.h (right): http://codereview.chromium.org/87013/diff/1/3#newcode76 Line 76: #define REGISTER_FROM_THREADSTATE(a,b) ((a)->__ ...
11 years, 8 months ago (2009-04-20 23:50:22 UTC) #2
jeremy
11 years, 8 months ago (2009-04-20 23:54:59 UTC) #3
Fixed, thanks :)

http://codereview.chromium.org/87013/diff/1/3
File client/mac/handler/minidump_generator.h (right):

http://codereview.chromium.org/87013/diff/1/3#newcode76
Line 76: #define REGISTER_FROM_THREADSTATE(a,b) ((a)->__ ## b)
On 2009/04/20 23:50:23, nealsid wrote:
> space after ,

Done.

http://codereview.chromium.org/87013/diff/1/3#newcode78
Line 78: #define REGISTER_FROM_THREADSTATE(a,b) (a->b)
On 2009/04/20 23:50:23, nealsid wrote:
> space after ,

Done.

Powered by Google App Engine
This is Rietveld 408576698