Issue 87013: Make breakpad compile against 10.5 SDK

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 87013: Make breakpad compile against 10.5 SDK (Closed)

Created:
11 years, 8 months ago by jeremy

Modified:
5 years, 1 month ago

Reviewers:
nealsid

CC:
chromium-reviews_googlegroups.com, google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/src/

Visibility:
Public.

Description

Add paranoid logging to reporter and inspector I keep needing to add this manually every time I need to debug breakpad, better to just have it in the main source.

Patch Set 5 : '' #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -6 lines)			Patch
M	client/mac/crash_generation/Inspector.mm	View		5 chunks	+22 lines, -3 lines	0 comments	Download
M	client/mac/sender/crash_report_sender.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	client/mac/sender/crash_report_sender.m	View	3	5 chunks	+37 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nealsid

+google-breakpad-dev@googlegroups.com LGTM with minor nits http://codereview.chromium.org/87013/diff/1/3 File client/mac/handler/minidump_generator.h (right): http://codereview.chromium.org/87013/diff/1/3#newcode76 Line 76: #define REGISTER_FROM_THREADSTATE(a,b) ((a)->__ ...

11 years, 8 months ago (2009-04-20 23:50:22 UTC) #2

jeremy

11 years, 8 months ago (2009-04-20 23:54:59 UTC) #3

Fixed, thanks :)

http://codereview.chromium.org/87013/diff/1/3
File client/mac/handler/minidump_generator.h (right):

http://codereview.chromium.org/87013/diff/1/3#newcode76
Line 76: #define REGISTER_FROM_THREADSTATE(a,b) ((a)->__ ## b)
On 2009/04/20 23:50:23, nealsid wrote:
> space after ,

Done.

http://codereview.chromium.org/87013/diff/1/3#newcode78
Line 78: #define REGISTER_FROM_THREADSTATE(a,b) (a->b)
On 2009/04/20 23:50:23, nealsid wrote:
> space after ,

Done.

Expand Messages | Collapse Messages

Issue 87013: Make breakpad compile against 10.5 SDK (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Messages