Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 8701010: Revert 111618 - Reapply of http://codereview.chromium.org/8632023/ (Closed)

Created:
9 years ago by noelallen1
Modified:
9 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 111618 - Reapply of http://codereview.chromium.org/8632023/ The original CL failed on Mac. Avoid references to untrusted.gypi in WebKit Remove include of untrusted.gypi in normal ppapi gyp files to prevent WebKit from depending on NaCl. Refactor PPAPI gyp files to pull out source lists which are shared between trusted and untrusted targets. Fix scons hack which pulls list of sources from GYP so that we can build with scons. This CL should allow us to revert the DEPS change: http://trac.webkit.org/changeset/101011 on the webkit side BUG= none TEST= Tools/Scripts/update-webkit --chromium TRB= dmichael@chromium.org Review URL: http://codereview.chromium.org/8701008 TBR=noelallen@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111621

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+588 lines, -495 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/native_client/src/shared/ppapi/nacl.scons View 1 chunk +4 lines, -11 lines 0 comments Download
M ppapi/ppapi.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/ppapi_cpp.gypi View 5 chunks +395 lines, -9 lines 0 comments Download
M ppapi/ppapi_internal.gyp View 1 chunk +1 line, -1 line 0 comments Download
D ppapi/ppapi_sources.gypi View 1 chunk +0 lines, -351 lines 0 comments Download
M ppapi/ppapi_tests.gypi View 3 chunks +185 lines, -1 line 0 comments Download
D ppapi/ppapi_untrusted.gyp View 1 chunk +0 lines, -119 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
noelallen1
9 years ago (2011-11-25 23:55:25 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698