Issue 8701008: Reapply of http://codereview.chromium.org/8632023/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8701008: Reapply of http://codereview.chromium.org/8632023/ (Closed)

Created:
9 years ago by noelallen1

Modified:
9 years ago

Reviewers:

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Reapply of http://codereview.chromium.org/8632023/ The original CL failed on Mac. Avoid references to untrusted.gypi in WebKit Remove include of untrusted.gypi in normal ppapi gyp files to prevent WebKit from depending on NaCl. Refactor PPAPI gyp files to pull out source lists which are shared between trusted and untrusted targets. Fix scons hack which pulls list of sources from GYP so that we can build with scons. This CL should allow us to revert the DEPS change: http://trac.webkit.org/changeset/101011 on the webkit side BUG= none TEST= Tools/Scripts/update-webkit --chromium TRB= dmichael@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111618

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+495 lines, -588 lines)			Patch
M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_tests.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/native_client/src/shared/ppapi/nacl.scons	View		1 chunk	+11 lines, -4 lines	0 comments	Download
M	ppapi/ppapi.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/ppapi_cpp.gypi	View	1	5 chunks	+9 lines, -395 lines	0 comments	Download
M	ppapi/ppapi_internal.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download
A	ppapi/ppapi_sources.gypi	View	1	1 chunk	+351 lines, -0 lines	0 comments	Download
M	ppapi/ppapi_tests.gypi	View		3 chunks	+1 line, -185 lines	0 comments	Download
A	ppapi/ppapi_untrusted.gyp	View	1	1 chunk	+119 lines, -0 lines	0 comments	Download