Switch to using the LLVM gold plugin as a fully linked-in object rather than DSO.

Switch to using the LLVM gold plugin as a fully linked-in object rather than DSO.

Before (text size only):

  ld.gold          2.5 MB
  libLTO.so       15.2 MB
  libLLVMgold.so  300 KB

After:

  ld.gold         16 MB

For comparison, clang is 33 MB, and llc is 14 MB.

This creates a dependency on LLVM for binutils, which requires changing the build order to so that LLVM
is built first.

This will fix the DSO loading problems seen on Windows under Cygwin.

There are two pre-requisite CLs:
  http://codereview.chromium.org/8713008/
  http://codereview.chromium.org/8714005/

BUG= http://code.google.com/p/nativeclient/issues/detail?id=2286
Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=7835

[jasonwkim, 2011-11-28 18:28:30]

On Sun, Nov 27, 2011 at 9:18 PM, <pdox@google.com> wrote:

> Reviewers: krasin, robertm, nlewycky,
>
> Description:
> Switch to using the LLVM gold plugin as a fully linked-in object rather
> than
> DSO.
>
> Before (text size only):
>
>  ld.gold          2.5 MB
>  libLTO.so       15.2 MB
>  libLLVMgold.so  300 KB
>
> After:
>
>  ld.gold         16 MB
>
> For comparison, clang is 33 MB, and llc is 14 MB.
>
> This creates a dependency on LLVM for binutils, which requires changing the
> build order to so that LLVM
> is built first.
>
> This will fix the DSO loading problems seen on Windows under Cygwin.
>
>
This seems like a band-aid solution for windows at the cost of yet another
build dependency.
We need to find a better solution for the DLL loading issue instead of
something like this.



> There are two pre-requisite CLs:
> 
http://codereview.chromium.**org/8713008/<http://codereview.chromium.org/8713...
> 
http://codereview.chromium.**org/8714005/<http://codereview.chromium.org/8714...
>
> BUG=
http://code.google.com/p/**nativeclient/issues/detail?id=**2286<http://code.g...
>
> Please review this at
http://codereview.chromium.**org/8698014/<http://codereview.chromium.org/8698...
>
> SVN Base: svn://svn.chromium.org/native_**client/trunk/src/native_**
> client/ <http://svn.chromium.org/native_client/trunk/src/native_client/>
>
> Affected files:
>  M     pnacl/build.sh
>  M     pnacl/driver/pnacl-ar.py
>  M     pnacl/driver/pnacl-ld.py
>  M     pnacl/driver/pnacl-nm.py
>  M     pnacl/driver/pnacl-ranlib.py
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "Native-Client-Reviews" group.
> To post to this group, send email to native-client-reviews@**
> googlegroups.com <native-client-reviews@googlegroups.com>.
> To unsubscribe from this group, send email to native-client-reviews+**
>
unsubscribe@googlegroups.com<native-client-reviews%2Bunsubscribe@googlegroups...
> .
> For more options, visit this group at http://groups.google.com/**
>
group/native-client-reviews?**hl=en<http://groups.google.com/group/native-client-reviews?hl=en>
> .
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.

[jasonwkim, 2011-11-28 18:56:20]

On Mon, Nov 28, 2011 at 10:27 AM, Jason Kim <jasonwkim@google.com> wrote:

>
>
> On Sun, Nov 27, 2011 at 9:18 PM, <pdox@google.com> wrote:
>
>> Reviewers: krasin, robertm, nlewycky,
>>
>> Description:
>> Switch to using the LLVM gold plugin as a fully linked-in object rather
>> than
>> DSO.
>>
>> Before (text size only):
>>
>>  ld.gold          2.5 MB
>>  libLTO.so       15.2 MB
>>  libLLVMgold.so  300 KB
>>
>> After:
>>
>>  ld.gold         16 MB
>>
>> For comparison, clang is 33 MB, and llc is 14 MB.
>>
>> This creates a dependency on LLVM for binutils, which requires changing
>> the
>> build order to so that LLVM
>> is built first.
>>
>> This will fix the DSO loading problems seen on Windows under Cygwin.
>>
>>
> This seems like a band-aid solution for windows at the cost of yet another
> build dependency.
> We need to find a better solution for the DLL loading issue instead of
> something like this.
>
>
Wait. Are these CL's for making gold statically linked on all platforms?


>
>
>> There are two pre-requisite CLs:
>> 
http://codereview.chromium.**org/8713008/<http://codereview.chromium.org/8713...
>> 
http://codereview.chromium.**org/8714005/<http://codereview.chromium.org/8714...
>>
>> BUG=
http://code.google.com/p/**nativeclient/issues/detail?id=**2286<http://code.g...
>>
>> Please review this at
http://codereview.chromium.**org/8698014/<http://codereview.chromium.org/8698...
>>
>> SVN Base: svn://svn.chromium.org/native_**client/trunk/src/native_**
>> client/ <http://svn.chromium.org/native_client/trunk/src/native_client/>
>>
>> Affected files:
>>  M     pnacl/build.sh
>>  M     pnacl/driver/pnacl-ar.py
>>  M     pnacl/driver/pnacl-ld.py
>>  M     pnacl/driver/pnacl-nm.py
>>  M     pnacl/driver/pnacl-ranlib.py
>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Native-Client-Reviews" group.
>> To post to this group, send email to native-client-reviews@**
>> googlegroups.com <native-client-reviews@googlegroups.com>.
>> To unsubscribe from this group, send email to native-client-reviews+**
>>
unsubscribe@googlegroups.com<native-client-reviews%2Bunsubscribe@googlegroups...
>> .
>> For more options, visit this group at http://groups.google.com/**
>>
group/native-client-reviews?**hl=en<http://groups.google.com/group/native-client-reviews?hl=en>
>> .
>>
>>
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.

[pdox, 2011-11-28 19:42:50]

yes, it does the same thing on all platforms

[jvoung - send to chromium..., 2012-02-18 00:10:39]

otherwise, lgtm

https://chromiumcodereview.appspot.com/8698014/diff/10002/pnacl/driver/pnacl-...
File pnacl/driver/pnacl-ld.py (left):

https://chromiumcodereview.appspot.com/8698014/diff/10002/pnacl/driver/pnacl-...
pnacl/driver/pnacl-ld.py:60: 'GOLD_PLUGIN_ARGS': '-plugin=${GOLD_PLUGIN_SO} ' +
can the GOLD_PLUGIN_SO variable be removed too?

[pdox, 2012-02-18 00:15:59]

https://chromiumcodereview.appspot.com/8698014/diff/10002/pnacl/driver/pnacl-...
File pnacl/driver/pnacl-ld.py (left):

https://chromiumcodereview.appspot.com/8698014/diff/10002/pnacl/driver/pnacl-...
pnacl/driver/pnacl-ld.py:60: 'GOLD_PLUGIN_ARGS': '-plugin=${GOLD_PLUGIN_SO} ' +
On 2012/02/18 00:10:39, jvoung wrote:
> can the GOLD_PLUGIN_SO variable be removed too?

Done.

[jvoung - send to chromium..., 2012-06-22 19:58:49]

http://codereview.chromium.org/8698014/diff/14002/pnacl/build.sh
File pnacl/build.sh (right):

http://codereview.chromium.org/8698014/diff/14002/pnacl/build.sh#newcode1265
pnacl/build.sh:1265: -o "${LLVM_GOLD_PLUGIN}"
Perhaps this shouldn't have been a single .o file (gold-plugin-static.o), but a
new static archive with libLTO + the gold-plugin.o.

Then, when we wouldn't have libLTO as a giant unit (a .o), when we build
binutils.