chrome/browser/automation/testing_automation_provider.cc - Issue 8697006: DownloadManager intereface refactoring to allow cleaner DownloadItem unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/automation/testing_automation_provider.cc

Issue 8697006: DownloadManager intereface refactoring to allow cleaner DownloadItem unit tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Improved isolation of MockDownloadManager. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/automation/testing_automation_provider.cc

diff --git a/chrome/browser/automation/testing_automation_provider.cc b/chrome/browser/automation/testing_automation_provider.cc

index a6011e3a432c87cf18d54f53f16b93c2656b960d..fe5c4b0f14e32033d6ae7ada34a6793e978b769c 100644

--- a/chrome/browser/automation/testing_automation_provider.cc

+++ b/chrome/browser/automation/testing_automation_provider.cc

@@ -3163,7 +3163,7 @@ void TestingAutomationProvider::PerformActionOnDownload(

selected_item->OpenDownload();

} else if (action == "toggle_open_files_like_this") {

DownloadPrefs* prefs =

- DownloadPrefs::FromDownloadManager(selected_item->GetDownloadManager());

+ DownloadPrefs::FromBrowserContext(selected_item->BrowserContext());

FilePath path = selected_item->GetUserVerifiedFilePath();

if (!selected_item->ShouldOpenFileBasedOnExtension())

prefs->EnableAutoOpenBasedOnExtension(path);

« no previous file with comments | « no previous file | chrome/browser/download/download_item_unittest.cc » ('j') | chrome/browser/download/download_prefs.cc » ('J')