DownloadManager intereface refactoring to allow cleaner DownloadItem unit tests.

chrome/browser/download/download_prefs.cc

Index: chrome/browser/download/download_prefs.cc
diff --git a/chrome/browser/download/download_prefs.cc b/chrome/browser/download/download_prefs.cc
index feced8d092b91f6d9f62d61d794239569949db79..48c2f6d66132b0d4f6f9d3b0c80a103a3afc0fe0 100644
--- a/chrome/browser/download/download_prefs.cc
+++ b/chrome/browser/download/download_prefs.cc
@@ -14,12 +14,15 @@
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/download/chrome_download_manager_delegate.h"
 #include "chrome/browser/download/download_extensions.h"
+#include "chrome/browser/download/download_service.h"
 #include "chrome/browser/download/download_util.h"
 #include "chrome/browser/prefs/pref_service.h"
+#include "chrome/browser/profiles/profile.h"
 #include "chrome/common/pref_names.h"
 #include "content/browser/download/download_manager.h"
 #include "content/browser/download/save_package.h"
 #include "content/public/browser/browser_thread.h"
+#include "chrome/browser/download/download_service_factory.h"
 
 using content::BrowserThread;
 
@@ -102,6 +105,18 @@ DownloadPrefs* DownloadPrefs::FromDownloadManager(
   return delegate->download_prefs();
 }
 
+// static
+DownloadPrefs* DownloadPrefs::FromBrowserContext(
+    content::BrowserContext* browser_context) {
+  Profile* profile = static_cast<Profile*>(browser_context);
+  DownloadService* download_service =
+      DownloadServiceFactory::GetForProfile(profile);
+  ChromeDownloadManagerDelegate* delegate =

[ahendrickson, 2011/11/29 21:40:15]

This part should call FromDownloadManager().

[Randy Smith (Not in Mondays), 2011/11/30 22:44:05]

Ok, but long term I want to get DownloadManager out of this pathway.  But then,
long-term I'd like to nuke this pathway, so that may be moot :-}.

+      static_cast<ChromeDownloadManagerDelegate*>(
+          download_service->GetDownloadManager()->delegate());
+  return delegate->download_prefs();
+}
+
 bool DownloadPrefs::PromptForDownload() const {
   // If the DownloadDirectory policy is set, then |prompt_for_download_| should
   // always be false.