Implement confirm bubble for Mac.

chrome/browser/ui/confirm_bubble_model.cc

Index: chrome/browser/ui/confirm_bubble_model.cc
===================================================================
--- chrome/browser/ui/confirm_bubble_model.cc	(revision 111570)
+++ chrome/browser/ui/confirm_bubble_model.cc	(working copy)
@@ -41,6 +41,7 @@
 void ConfirmBubbleModel::LinkClicked() {
 }
 
+#if !defined(OS_MACOSX)
 void ConfirmBubbleModel::Show(gfx::NativeView view,

[tfarina, 2011/11/30 15:58:38]

This is better implemented as a free function.

May be something like:

confirm_bubble.h

namespace browser {

void ShowConfirmBubble(gfx::NativeView view,
                       const gfx::Point& origin,
                       ConfirmBubbleModel* model);

}  // namespace browser

And let the platform specific files implement it.

confirm_bubble_view.cc

#include "chrome/browser/ui/confirm_bubble.h

....

namespace browser {

void ShowConfirmBubble(...) {
...
}

}  // namespace browser

With that I think you can avoid having the model know about view and all these
ugly ifdefs!

[Hironori Bono, 2011/12/09 11:14:32]

Thanks for your suggestion. I'm implementing GTK code now and it may need more
changes to this function. When I finish implementing this function for all
platforms, I will refactor this class to remove this #ifdef.

                               const gfx::Point& origin,
                               ConfirmBubbleModel* model) {
@@ -59,4 +60,4 @@
   NOTIMPLEMENTED();  // Bug 99130: Implement it.
 #endif
 }
-
+#endif