Implement confirm bubble for Mac.

chrome/browser/ui/confirm_bubble_model.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/confirm_bubble_model.h"
 
 #include "base/logging.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 
@@ skipping 23 matching lines @@
 void ConfirmBubbleModel::Cancel() {
 }
 
 string16 ConfirmBubbleModel::GetLinkText() const {
   return string16();
 }
 
 void ConfirmBubbleModel::LinkClicked() {
 }
 
+#if !defined(OS_MACOSX)
 void ConfirmBubbleModel::Show(gfx::NativeView view,

[tfarina, 2011/11/30 15:58:38]

This is better implemented as a free function.

May be something like:

confirm_bubble.h

namespace browser {

void ShowConfirmBubble(gfx::NativeView view,
                       const gfx::Point& origin,
                       ConfirmBubbleModel* model);

}  // namespace browser

And let the platform specific files implement it.

confirm_bubble_view.cc

#include "chrome/browser/ui/confirm_bubble.h

....

namespace browser {

void ShowConfirmBubble(...) {
...
}

}  // namespace browser

With that I think you can avoid having the model know about view and all these
ugly ifdefs!

[Hironori Bono, 2011/12/09 11:14:32]

Thanks for your suggestion. I'm implementing GTK code now and it may need more
changes to this function. When I finish implementing this function for all
platforms, I will refactor this class to remove this #ifdef.

                               const gfx::Point& origin,
                               ConfirmBubbleModel* model) {
 #if defined(TOOLKIT_VIEWS)
   views::Widget* parent = views::Widget::GetTopLevelWidgetForNativeView(view);
   if (!parent)
     return;
 
   ConfirmBubbleView* bubble_view = new ConfirmBubbleView(model);
   Bubble* bubble = Bubble::Show(parent, gfx::Rect(origin, gfx::Size()),
                                 views::BubbleBorder::NONE,
                                 views::BubbleBorder::ALIGN_ARROW_TO_MID_ANCHOR,
                                 bubble_view, bubble_view);
   bubble->SizeToContents();
 #else
   NOTIMPLEMENTED();  // Bug 99130: Implement it.
 #endif
 }
-
+#endif