Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8689013: Remove TOUCH_UI specific new tab page. (Closed)

Created:
9 years, 1 month ago by Rick Byers
Modified:
9 years ago
Reviewers:
Evan Stade
CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews), pam+watch_chromium.org
Visibility:
Public.

Description

Remove TOUCH_UI specific new tab page. Also remove and clean-up the remaining vestiges of NTP3 support (they were left n the code just for touch_ntp which was built against them). BUG=105046 TEST=NTP4WebUITest.TestBrowsePages Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112229

Patch Set 1 #

Patch Set 2 : Finish clean-up #

Patch Set 3 : Merge with trunk #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5557 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/browser/resources/new_tab.css View 1 2 1 chunk +0 lines, -604 lines 0 comments Download
D chrome/browser/resources/new_tab.js View 1 1 chunk +0 lines, -1489 lines 0 comments Download
D chrome/browser/resources/touch_ntp/grabber.js View 1 chunk +0 lines, -383 lines 0 comments Download
D chrome/browser/resources/touch_ntp/newtab.css View 1 chunk +0 lines, -217 lines 0 comments Download
D chrome/browser/resources/touch_ntp/newtab.html View 1 chunk +0 lines, -61 lines 0 comments Download
D chrome/browser/resources/touch_ntp/newtab.js View 1 chunk +0 lines, -805 lines 0 comments Download
D chrome/browser/resources/touch_ntp/slider.js View 1 chunk +0 lines, -336 lines 0 comments Download
D chrome/browser/resources/touch_ntp/standalone/entaglement-icon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/touch_ntp/standalone/gmail-favicon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/touch_ntp/standalone/gmail-icon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/touch_ntp/standalone/googlebooks-favicon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/touch_ntp/standalone/googlebooks-icon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/touch_ntp/standalone/googlemaps-favicon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/touch_ntp/standalone/googlemaps-icon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/touch_ntp/standalone/googletalk-icon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/touch_ntp/standalone/nytimes-icon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/touch_ntp/standalone/poppit-favicon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/touch_ntp/standalone/poppit-icon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/touch_ntp/standalone/standalone_hack.js View 1 chunk +0 lines, -562 lines 0 comments Download
D chrome/browser/resources/touch_ntp/standalone/webstore_icon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/touch_ntp/standalone/youtube-icon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/touch_ntp/tools/check.sh View 1 chunk +0 lines, -58 lines 0 comments Download
D chrome/browser/resources/touch_ntp/tools/externs.js View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/browser/resources/touch_ntp/touchhandler.js View 1 chunk +0 lines, -850 lines 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 1 13 chunks +24 lines, -66 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_page_handler.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui.h View 1 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui.cc View 1 5 chunks +4 lines, -34 lines 2 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 1 2 chunks +5 lines, -37 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/test/data/webui/ntp4.js View 1 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Rick Byers
Evan, Can you please review this? Thanks, Rick
9 years ago (2011-11-25 22:25:37 UTC) #1
Evan Stade
lgtm http://codereview.chromium.org/8689013/diff/5001/chrome/browser/ui/webui/ntp/new_tab_ui.cc File chrome/browser/ui/webui/ntp/new_tab_ui.cc (left): http://codereview.chromium.org/8689013/diff/5001/chrome/browser/ui/webui/ntp/new_tab_ui.cc#oldcode203 chrome/browser/ui/webui/ntp/new_tab_ui.cc:203: CallJavascriptFunction("bookmarkBarDetached"); technically, I think we may need this ...
9 years ago (2011-11-30 03:42:20 UTC) #2
Rick Byers
Thanks Evan! http://codereview.chromium.org/8689013/diff/5001/chrome/browser/ui/webui/ntp/new_tab_ui.cc File chrome/browser/ui/webui/ntp/new_tab_ui.cc (left): http://codereview.chromium.org/8689013/diff/5001/chrome/browser/ui/webui/ntp/new_tab_ui.cc#oldcode203 chrome/browser/ui/webui/ntp/new_tab_ui.cc:203: CallJavascriptFunction("bookmarkBarDetached"); On 2011/11/30 03:42:20, Evan Stade wrote: ...
9 years ago (2011-11-30 14:29:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/8689013/5001
9 years ago (2011-11-30 14:30:36 UTC) #4
commit-bot: I haz the power
9 years ago (2011-11-30 15:43:28 UTC) #5 
Change committed as 112229

Powered by Google App Engine
This is Rietveld 408576698