Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: chrome/browser/ui/webui/ntp/ntp_resource_cache.cc

Issue 8689013: Remove TOUCH_UI specific new tab page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge with trunk Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
diff --git a/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc b/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
index f34bd5a13e4bad9c2f3f289753b72d3cddb930d6..efe04f7a9293d831c25a83d5916ec56620755d58 100644
--- a/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
+++ b/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
@@ -424,41 +424,11 @@ void NTPResourceCache::CreateNewTabHTML() {
NewTabUI::NTP4BookmarkFeaturesEnabled() ? "true" : "false");
// Load the new tab page appropriate for this build
- // Note that some builds (eg. TOUCHUI) don't make use of everything we
- // do here (all of the template data, etc.), but we keep the back end
- // consistent across builds, supporting the union of all NTP front-ends
- // for simplicity.
std::string full_html;
- if (NewTabUI::NTP4Enabled()) {
- base::StringPiece new_tab_html(ResourceBundle::GetSharedInstance().
- GetRawDataResource(IDR_NEW_TAB_4_HTML));
- full_html = jstemplate_builder::GetI18nTemplateHtml(new_tab_html,
- &localized_strings);
- } else {
- base::StringPiece new_tab_html(ResourceBundle::GetSharedInstance().
- GetRawDataResource(IDR_NEW_TAB_HTML));
-
- // Inject the template data into the HTML so that it is available before any
- // layout is needed.
- std::string json_html;
- jstemplate_builder::AppendJsonHtml(&localized_strings, &json_html);
-
- static const base::StringPiece template_data_placeholder(
- "<!-- template data placeholder -->");
- size_t pos = new_tab_html.find(template_data_placeholder);
-
- if (pos != base::StringPiece::npos) {
- full_html.assign(new_tab_html.data(), pos);
- full_html.append(json_html);
- size_t after_offset = pos + template_data_placeholder.size();
- full_html.append(new_tab_html.data() + after_offset,
- new_tab_html.size() - after_offset);
- } else {
- NOTREACHED();
- full_html.assign(new_tab_html.data(), new_tab_html.size());
- }
- }
-
+ base::StringPiece new_tab_html(ResourceBundle::GetSharedInstance().
+ GetRawDataResource(IDR_NEW_TAB_4_HTML));
+ full_html = jstemplate_builder::GetI18nTemplateHtml(new_tab_html,
+ &localized_strings);
new_tab_html_ = base::RefCountedString::TakeString(&full_html);
}
@@ -579,11 +549,9 @@ void NTPResourceCache::CreateNewTabCSS() {
subst.push_back(SkColorToRGBComponents(color_text)); // $23
// Get our template.
- int ntp_css_resource_id = NewTabUI::NTP4Enabled() ?
- IDR_NEW_TAB_4_THEME_CSS : IDR_NEW_TAB_THEME_CSS;
static const base::StringPiece new_tab_theme_css(
ResourceBundle::GetSharedInstance().GetRawDataResource(
- ntp_css_resource_id));
+ IDR_NEW_TAB_4_THEME_CSS));
// Create the string from our template and the replacements.
std::string css_string;

Powered by Google App Engine
This is Rietveld 408576698