Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/webui/ntp/ntp_resource_cache.cc

Issue 8689006: Create a field test for sync sign in promo strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Addressed sail's comments Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/sync_promo.js ('k') | chrome/browser/ui/webui/sync_promo_handler.h » ('j') | chrome/browser/ui/webui/sync_promo_trial.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
===================================================================
--- chrome/browser/ui/webui/ntp/ntp_resource_cache.cc (revision 111699)
+++ chrome/browser/ui/webui/ntp/ntp_resource_cache.cc (working copy)
@@ -377,7 +377,7 @@
NewTabPageHandler::GetLocalizedValues(profile_, &localized_strings);
NTPLoginHandler::GetLocalizedValues(profile_, &localized_strings);
- SyncSetupHandler::GetStaticLocalizedValues(&localized_strings);
+ SyncSetupHandler::GetStaticLocalizedValues(&localized_strings, NULL);
sail 2011/11/28 20:14:02 Hm.. this may not be needed anymore. I'll take a l
sail 2011/11/28 20:33:09 Just verified. None of the strings in SyncSetupHan
SteveT 2011/11/28 20:40:59 Done.
// Don't initiate the sync related message passing with the page if the sync
// code is not present.
« no previous file with comments | « chrome/browser/resources/sync_promo.js ('k') | chrome/browser/ui/webui/sync_promo_handler.h » ('j') | chrome/browser/ui/webui/sync_promo_trial.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698