Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Side by Side Diff: chrome/browser/ui/webui/ntp/ntp_resource_cache.cc

Issue 8689006: Create a field test for sync sign in promo strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Addressed sail's comments Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/ntp/ntp_resource_cache.h" 5 #include "chrome/browser/ui/webui/ntp/ntp_resource_cache.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/file_util.h" 10 #include "base/file_util.h"
(...skipping 359 matching lines...) Expand 10 before | Expand all | Expand 10 after
370 localized_strings.SetString("importDataLinkTitle", 370 localized_strings.SetString("importDataLinkTitle",
371 l10n_util::GetStringUTF16(IDS_NEW_TAB_BOOKMARKS_IMPORT_LINK_TITLE)); 371 l10n_util::GetStringUTF16(IDS_NEW_TAB_BOOKMARKS_IMPORT_LINK_TITLE));
372 #if defined(OS_CHROMEOS) 372 #if defined(OS_CHROMEOS)
373 localized_strings.SetString("expandMenu", 373 localized_strings.SetString("expandMenu",
374 l10n_util::GetStringUTF16(IDS_NEW_TAB_CLOSE_MENU_EXPAND)); 374 l10n_util::GetStringUTF16(IDS_NEW_TAB_CLOSE_MENU_EXPAND));
375 #endif 375 #endif
376 376
377 NewTabPageHandler::GetLocalizedValues(profile_, &localized_strings); 377 NewTabPageHandler::GetLocalizedValues(profile_, &localized_strings);
378 NTPLoginHandler::GetLocalizedValues(profile_, &localized_strings); 378 NTPLoginHandler::GetLocalizedValues(profile_, &localized_strings);
379 379
380 SyncSetupHandler::GetStaticLocalizedValues(&localized_strings); 380 SyncSetupHandler::GetStaticLocalizedValues(&localized_strings, NULL);
sail 2011/11/28 20:14:02 Hm.. this may not be needed anymore. I'll take a l
sail 2011/11/28 20:33:09 Just verified. None of the strings in SyncSetupHan
SteveT 2011/11/28 20:40:59 Done.
381 381
382 // Don't initiate the sync related message passing with the page if the sync 382 // Don't initiate the sync related message passing with the page if the sync
383 // code is not present. 383 // code is not present.
384 if (profile_->GetProfileSyncService()) 384 if (profile_->GetProfileSyncService())
385 localized_strings.SetString("syncispresent", "true"); 385 localized_strings.SetString("syncispresent", "true");
386 else 386 else
387 localized_strings.SetString("syncispresent", "false"); 387 localized_strings.SetString("syncispresent", "false");
388 388
389 ChromeURLDataManager::DataSource::SetFontAndTextDirection(&localized_strings); 389 ChromeURLDataManager::DataSource::SetFontAndTextDirection(&localized_strings);
390 390
(...skipping 192 matching lines...) Expand 10 before | Expand all | Expand 10 after
583 IDR_NEW_TAB_4_THEME_CSS : IDR_NEW_TAB_THEME_CSS; 583 IDR_NEW_TAB_4_THEME_CSS : IDR_NEW_TAB_THEME_CSS;
584 static const base::StringPiece new_tab_theme_css( 584 static const base::StringPiece new_tab_theme_css(
585 ResourceBundle::GetSharedInstance().GetRawDataResource( 585 ResourceBundle::GetSharedInstance().GetRawDataResource(
586 ntp_css_resource_id)); 586 ntp_css_resource_id));
587 587
588 // Create the string from our template and the replacements. 588 // Create the string from our template and the replacements.
589 std::string css_string; 589 std::string css_string;
590 css_string = ReplaceStringPlaceholders(new_tab_theme_css, subst, NULL); 590 css_string = ReplaceStringPlaceholders(new_tab_theme_css, subst, NULL);
591 new_tab_css_ = base::RefCountedString::TakeString(&css_string); 591 new_tab_css_ = base::RefCountedString::TakeString(&css_string);
592 } 592 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698