Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 8687025: Add runtime/include to libdart includes. (Closed)

Created:
9 years ago by podivilov
Modified:
9 years ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add runtime/include to libdart includes. R=iposva@google.com

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M runtime/dart-runtime.gyp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
podivilov
9 years ago (2011-11-29 10:54:38 UTC) #1
podivilov
9 years ago (2011-11-30 10:51:31 UTC) #2
Ivan Posva
LGTM, as long as this does not negatively impact the local build targets. -Ivan
9 years ago (2011-12-01 18:21:04 UTC) #3
podivilov
9 years ago (2011-12-06 12:53:14 UTC) #4
On 2011/12/01 18:21:04, Ivan Posva wrote:
> LGTM, as long as this does not negatively impact the local build targets.
> 
> -Ivan

Landed at https://code.google.com/p/dart/source/detail?r=2082.

Powered by Google App Engine
This is Rietveld 408576698