Remove a few static initializers.

webkit/plugins/npapi/plugin_list.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/plugins/npapi/plugin_list.h"
 
 #include <algorithm>
 
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
@@ skipping 57 matching lines @@
 static const VersionRangeDefinition kShockwaveVersionRange[] = {
     { "",  "", "11.6.1.629", true }
 };
 static const VersionRangeDefinition kSilverlightVersionRange[] = {
     { "0", "4", "3.0.50611.0", false },
     { "4", "5", "", false }
 };
 
 // Similarly, try and share the group definition for plug-ins that are
 // very consistent across OS'es.
-static const PluginGroupDefinition kFlashDefinition = {
-    "adobe-flash-player", "Flash", "Shockwave Flash", kFlashVersionRange,
-    arraysize(kFlashVersionRange), "http://get.adobe.com/flashplayer/" };
+#define kFlashDefinition { \

[Bernhard Bauer, 2011/11/29 00:29:21]

Does this mean that arrays are okay, but POD structs aren't?

[Nico, 2011/11/29 00:31:39]

It's still a POD struct, it's just that the array below that references this
isn't initialized through a const global but through an initializer list. Here's
a small repro case:

This produces a static initializer:

struct PluginGroupDefinition {
  const char* const identifier;
};
const PluginGroupDefinition kFlashDefinition = { "adobe-flash-player"};
static const PluginGroupDefinition kGroupDefinitions[] = {
  kFlashDefinition
};


This doesn't:

struct PluginGroupDefinition {
  const char* const identifier;
};
#define kFlashDefinition { "adobe-flash-player"}
static const PluginGroupDefinition kGroupDefinitions[] = {
  kFlashDefinition
};

(Only the kFlashDefinition definition line is different. That's with gcc 4.4.3;
clang gets it right either way.)

+    "adobe-flash-player", "Flash", "Shockwave Flash", kFlashVersionRange,\
+    arraysize(kFlashVersionRange), "http://get.adobe.com/flashplayer/" }
 
-static const PluginGroupDefinition kShockwaveDefinition = {
-    "shockwave", PluginGroup::kShockwaveGroupName, "Shockwave for Director",
-    kShockwaveVersionRange, arraysize(kShockwaveVersionRange),
-    "http://www.adobe.com/shockwave/download/" };
+#define kShockwaveDefinition { \
+    "shockwave", PluginGroup::kShockwaveGroupName, "Shockwave for Director", \
+    kShockwaveVersionRange, arraysize(kShockwaveVersionRange), \
+    "http://www.adobe.com/shockwave/download/" }
 
-static const PluginGroupDefinition kSilverlightDefinition = {
-    "silverlight", PluginGroup::kSilverlightGroupName, "Silverlight",
-    kSilverlightVersionRange, arraysize(kSilverlightVersionRange),
-    "http://www.microsoft.com/getsilverlight/" };
+#define kSilverlightDefinition { \
+    "silverlight", PluginGroup::kSilverlightGroupName, "Silverlight", \
+    kSilverlightVersionRange, arraysize(kSilverlightVersionRange), \
+    "http://www.microsoft.com/getsilverlight/" }
 
 #if defined(OS_MACOSX)
 // Plugin Groups for Mac.
 // Plugins are listed here as soon as vulnerabilities and solutions
 // (new versions) are published.
 static const VersionRangeDefinition kQuicktimeVersionRange[] = {
     { "", "", "7.6.6", true }
 };
 static const VersionRangeDefinition kJavaVersionRange[] = {
     { "0", "13.0", "12.8.0", true },  // Leopard
@@ skipping 647 matching lines @@
   }
   return false;
 }
 
 PluginList::~PluginList() {
 }
 
 
 }  // namespace npapi
 }  // namespace webkit