Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: chrome/browser/ui/panels/native_panel.h

Issue 8686012: Make panels not show on top when there is an app running in full screen mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Code review feedback. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/native_panel.h
diff --git a/chrome/browser/ui/panels/native_panel.h b/chrome/browser/ui/panels/native_panel.h
index 4d1581d81b2273b86d9e09523001176f5c693616..dcfd4f4bd5e0b354c99d1b2f31f47140969e8fc8 100644
--- a/chrome/browser/ui/panels/native_panel.h
+++ b/chrome/browser/ui/panels/native_panel.h
@@ -28,10 +28,7 @@ class Rect;
// still use the BrowserWindow interface as part of their implementation so we
// use Panel in all the method names to avoid collisions.
class NativePanel {
- friend class Panel;
- friend class PanelBrowserTest;
-
- protected:
+ public:
jennb 2011/12/01 20:10:33 Why not keep protected and have all panel strips g
Dmitry Titov 2011/12/01 20:14:45 I answered this above. It creates a lot of 'retran
virtual ~NativePanel() {}
virtual void ShowPanel() = 0;
@@ -59,6 +56,14 @@ class NativePanel {
virtual void HandlePanelKeyboardEvent(
const NativeWebKeyboardEvent& event) = 0;
+ // This function will only get called by one of the panel strips when full
+ // screen mode changes i.e it gets called when an app goes into full screen
+ // mode or when an app exits full screen mode. Panel should respond by making
+ // sure:
+ // a) it does not go on top when some app enters full screen mode.
+ // b) it remains on top when an app exits full screen mode.
+ virtual void FullScreenModeChanged(bool is_full_screen_mode_on) = 0;
+
virtual Browser* GetPanelBrowser() const = 0;
virtual void DestroyPanelBrowser() = 0;
« no previous file with comments | « no previous file | chrome/browser/ui/panels/panel_browser_view.h » ('j') | chrome/browser/ui/panels/panel_manager.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698