Make panels not show on top when there is an app running in full screen mode.

chrome/browser/ui/panels/native_panel.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_PANELS_NATIVE_PANEL_H_
 #define CHROME_BROWSER_UI_PANELS_NATIVE_PANEL_H_
 #pragma once
 
 #include "chrome/browser/ui/panels/panel.h"
 #include "ui/gfx/native_widget_types.h"
@@ skipping 10 matching lines @@
 // windows. We use this interface for two reasons:
 // 1. We don't want to use BrowserWindow as the interface between shared panel
 //    code and platform-specific code. BrowserWindow has a lot of methods, most
 //    of which we don't use and simply stub out with NOTIMPLEMENTED().
 // 2. We need some additional methods that BrowserWindow doesn't provide, such
 //    as MinimizePanel() and RestorePanel().
 // Note that even though we don't use BrowserWindow directly, Windows and GTK+
 // still use the BrowserWindow interface as part of their implementation so we
 // use Panel in all the method names to avoid collisions.
 class NativePanel {
-  friend class Panel;
-  friend class PanelBrowserTest;
-
- protected:
+ public:

[jennb, 2011/12/01 20:10:33]

Why not keep protected and have all panel strips go through Panel interface for
the full screen mode change?

[Dmitry Titov, 2011/12/01 20:14:45]

I answered this above. It creates a lot of 'retranslator' methods on Panel w/o
any benefit of encapsulation, actually.

   virtual ~NativePanel() {}
 
   virtual void ShowPanel() = 0;
   virtual void ShowPanelInactive() = 0;
   virtual gfx::Rect GetPanelBounds() const = 0;
   virtual void SetPanelBounds(const gfx::Rect& bounds) = 0;
   virtual void ClosePanel() = 0;
   virtual void ActivatePanel() = 0;
   virtual void DeactivatePanel() = 0;
   virtual bool IsPanelActive() const = 0;
   virtual gfx::NativeWindow GetNativePanelHandle() = 0;
   virtual void UpdatePanelTitleBar() = 0;
   virtual void UpdatePanelLoadingAnimations(bool should_animate) = 0;
   virtual void ShowTaskManagerForPanel() = 0;
   virtual FindBar* CreatePanelFindBar() = 0;
   virtual void NotifyPanelOnUserChangedTheme() = 0;
   virtual void PanelTabContentsFocused(TabContents* tab_contents) = 0;
   virtual void PanelCut() = 0;
   virtual void PanelCopy() = 0;
   virtual void PanelPaste() = 0;
   virtual void DrawAttention() = 0;
   virtual bool IsDrawingAttention() const = 0;
   virtual bool PreHandlePanelKeyboardEvent(
       const NativeWebKeyboardEvent& event, bool* is_keyboard_shortcut) = 0;
   virtual void HandlePanelKeyboardEvent(
       const NativeWebKeyboardEvent& event) = 0;
 
+  // This function will only get called by one of the panel strips when full
+  // screen mode changes i.e it gets called when an app goes into full screen
+  // mode or when an app exits full screen mode. Panel should respond by making
+  // sure:
+  // a) it does not go on top when some app enters full screen mode.
+  // b) it remains on top when an app exits full screen mode.
+  virtual void FullScreenModeChanged(bool is_full_screen_mode_on) = 0;
+
   virtual Browser* GetPanelBrowser() const = 0;
   virtual void DestroyPanelBrowser() = 0;
 
   // Returns the exterior size of the panel window given the client content
   // size and vice versa.
   virtual gfx::Size WindowSizeFromContentSize(
       const gfx::Size& content_size) const = 0;
   virtual gfx::Size ContentSizeFromWindowSize(
       const gfx::Size& window_size) const = 0;
 
@@ skipping 19 matching lines @@
   // Verifies, on a deepest possible level, if the native panel is really
   // active, i.e. the titlebar is painted per its active state.
   virtual bool VerifyActiveState(bool is_active) = 0;
   virtual void WaitForWindowCreationToComplete() const { }
 
   virtual bool IsWindowSizeKnown() const = 0;
   virtual bool IsAnimatingBounds() const = 0;
 };
 
 #endif  // CHROME_BROWSER_UI_PANELS_NATIVE_PANEL_H_