Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 8685001: Remove the Syzygy optimization alternative from GYP configs. (Closed)

Created:
9 years, 1 month ago by Sigurður Ásgeirsson
Modified:
9 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Remove the Syzygy optimization alternative from GYP configs. R=robertshield@chromium.org,rogerm@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111488

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Greg's comment. #

Patch Set 3 : Attemping another CQ commit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -88 lines) Patch
M chrome/chrome.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_dll.gypi View 1 3 chunks +4 lines, -23 lines 0 comments Download
D chrome/chrome_dll_syzygy.gypi View 1 chunk +0 lines, -52 lines 0 comments Download
M chrome/chrome_exe.gypi View 1 chunk +1 line, -12 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Roger McFarlane (Chromium)
lgtm good-bye code... <sniff>... it was fun while it lasted... <sniff>
9 years, 1 month ago (2011-11-23 21:43:57 UTC) #1
Sigurður Ásgeirsson
PTAL
9 years, 1 month ago (2011-11-23 21:49:37 UTC) #2
grt (UTC plus 2)
LGTM with one nit that you're welcome to ignore. http://codereview.chromium.org/8685001/diff/1/chrome/chrome_dll.gypi File chrome/chrome_dll.gypi (right): http://codereview.chromium.org/8685001/diff/1/chrome/chrome_dll.gypi#newcode12 chrome/chrome_dll.gypi:12: ...
9 years, 1 month ago (2011-11-23 22:03:11 UTC) #3
Sigurður Ásgeirsson
Thanks. http://codereview.chromium.org/8685001/diff/1/chrome/chrome_dll.gypi File chrome/chrome_dll.gypi (right): http://codereview.chromium.org/8685001/diff/1/chrome/chrome_dll.gypi#newcode12 chrome/chrome_dll.gypi:12: 'target_name': 'chrome_dll', On 2011/11/23 22:03:11, grt wrote: > ...
9 years, 1 month ago (2011-11-23 22:25:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/siggi@chromium.org/8685001/6001
9 years, 1 month ago (2011-11-23 22:30:24 UTC) #5
commit-bot: I haz the power
Try job failure for 8685001-6001 (retry) on mac_rel for step "compile" (clobber build). It's a ...
9 years, 1 month ago (2011-11-23 23:28:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/siggi@chromium.org/8685001/7002
9 years, 1 month ago (2011-11-24 02:05:16 UTC) #7
commit-bot: I haz the power
9 years, 1 month ago (2011-11-24 03:19:53 UTC) #8
Change committed as 111488

Powered by Google App Engine
This is Rietveld 408576698