Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Side by Side Diff: chrome/chrome_dll.gypi

Issue 8685001: Remove the Syzygy optimization alternative from GYP configs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Attemping another CQ commit. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/chrome.gyp ('k') | chrome/chrome_dll_syzygy.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 { 4 {
5 'conditions': [ 5 'conditions': [
6 ['OS=="mac" or OS=="win"', { 6 ['OS=="mac" or OS=="win"', {
7 'targets': [ 7 'targets': [
8 { 8 {
9 'target_name': 'chrome_dll',
10 'type': 'shared_library',
9 'variables': { 11 'variables': {
10 'enable_wexit_time_destructors': 1, 12 'enable_wexit_time_destructors': 1,
11 'conditions' : [
12 ['OS=="win" and optimize_with_syzygy==1', {
13 # On Windows we use build chrome_dll as an intermediate target
14 # then have a subsequent step which either optimizes it to its
15 # final location, or copies it to its final location, depending
16 # on whether or not optimize_with_syzygy==1. Please, refer to
17 # chrome_dll_syzygy.gypi for the subsequent defintion of the
18 # Windows chrome_dll target.
19 'dll_target_name': 'chrome_dll_initial',
20 }, {
21 'dll_target_name': 'chrome_dll',
22 }],
23 ],
24 }, 13 },
25 'target_name': '<(dll_target_name)',
26 'type': 'shared_library',
27 'dependencies': [ 14 'dependencies': [
28 '<@(chromium_dependencies)', 15 '<@(chromium_dependencies)',
29 'app/policy/cloud_policy_codegen.gyp:policy', 16 'app/policy/cloud_policy_codegen.gyp:policy',
30 ], 17 ],
31 'conditions': [ 18 'conditions': [
32 ['OS=="win"', { 19 ['OS=="win"', {
33 'product_name': 'chrome', 20 'product_name': 'chrome',
34 'dependencies': [ 21 'dependencies': [
35 # On Windows, link the dependencies (libraries) that make 22 # On Windows, link the dependencies (libraries) that make
36 # up actual Chromium functionality into this .dll. 23 # up actual Chromium functionality into this .dll.
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 }, 93 },
107 }, 94 },
108 'msvs_settings': { 95 'msvs_settings': {
109 'VCLinkerTool': { 96 'VCLinkerTool': {
110 'BaseAddress': '0x01c30000', 97 'BaseAddress': '0x01c30000',
111 'ImportLibrary': '$(OutDir)\\lib\\chrome_dll.lib', 98 'ImportLibrary': '$(OutDir)\\lib\\chrome_dll.lib',
112 'ProgramDatabaseFile': '$(OutDir)\\chrome_dll.pdb', 99 'ProgramDatabaseFile': '$(OutDir)\\chrome_dll.pdb',
113 # Set /SUBSYSTEM:WINDOWS for chrome.dll (for consistency). 100 # Set /SUBSYSTEM:WINDOWS for chrome.dll (for consistency).
114 'SubSystem': '2', 101 'SubSystem': '2',
115 'conditions': [ 102 'conditions': [
116 ['optimize_with_syzygy==1', { 103 ['incremental_chrome_dll==1', {
117 # When syzygy is enabled we use build chrome_dll as an
118 # intermediate target then have a subsequent step which
119 # optimizes it to its final location
120 'ProgramDatabaseFile': '$(OutDir)\\initial\\chrome_dll.pdb ',
121 'OutputFile': '$(OutDir)\\initial\\chrome.dll',
122 }], ['incremental_chrome_dll==1', {
123 'OutputFile': '$(OutDir)\\initial\\chrome.dll', 104 'OutputFile': '$(OutDir)\\initial\\chrome.dll',
124 'UseLibraryDependencyInputs': "true", 105 'UseLibraryDependencyInputs': "true",
125 }], 106 }],
126 ], 107 ],
127 'DelayLoadDLLs': [ 108 'DelayLoadDLLs': [
128 'comdlg32.dll', 109 'comdlg32.dll',
129 'crypt32.dll', 110 'crypt32.dll',
130 'cryptui.dll', 111 'cryptui.dll',
131 'dhcpcsvc.dll', 112 'dhcpcsvc.dll',
132 'imagehlp.dll', 113 'imagehlp.dll',
133 'imm32.dll', 114 'imm32.dll',
134 'iphlpapi.dll', 115 'iphlpapi.dll',
135 'setupapi.dll', 116 'setupapi.dll',
136 'urlmon.dll', 117 'urlmon.dll',
137 'winhttp.dll', 118 'winhttp.dll',
138 'wininet.dll', 119 'wininet.dll',
139 'winspool.drv', 120 'winspool.drv',
140 'ws2_32.dll', 121 'ws2_32.dll',
141 'wsock32.dll', 122 'wsock32.dll',
142 ], 123 ],
143 }, 124 },
144 'VCManifestTool': { 125 'VCManifestTool': {
145 'AdditionalManifestFiles': '$(ProjectDir)\\app\\chrome.dll.man ifest', 126 'AdditionalManifestFiles': '$(ProjectDir)\\app\\chrome.dll.man ifest',
146 }, 127 },
147 }, 128 },
148 'conditions': [ 129 'conditions': [
149 ['incremental_chrome_dll==1 and optimize_with_syzygy==0', { 130 ['incremental_chrome_dll==1', {
150 # Linking to a different directory and then hardlinking back 131 # Linking to a different directory and then hardlinking back
151 # to OutDir is a workaround to avoid having the .ilk for 132 # to OutDir is a workaround to avoid having the .ilk for
152 # chrome.exe and chrome.dll conflicting. See crbug.com/92528 133 # chrome.exe and chrome.dll conflicting. See crbug.com/92528
153 # for more information. Done on the dll instead of the exe so 134 # for more information. Done on the dll instead of the exe so
154 # that people launching from VS don't need to modify 135 # that people launching from VS don't need to modify
155 # $(TargetPath) for the exe. 136 # $(TargetPath) for the exe.
156 'msvs_postbuild': 'tools\\build\\win\\hardlink_failsafe.bat $( OutDir)\\initial\\chrome.dll $(OutDir)\\chrome.dll' 137 'msvs_postbuild': 'tools\\build\\win\\hardlink_failsafe.bat $( OutDir)\\initial\\chrome.dll $(OutDir)\\chrome.dll'
157 }] 138 }]
158 ] 139 ]
159 }], # OS=="win" 140 }], # OS=="win"
(...skipping 356 matching lines...) Expand 10 before | Expand all | Expand 10 after
516 ], 497 ],
517 }], 498 }],
518 ], # conditions 499 ], # conditions
519 }], # OS=="mac" 500 }], # OS=="mac"
520 ], # conditions 501 ], # conditions
521 }, # target chrome_dll 502 }, # target chrome_dll
522 ], # targets 503 ], # targets
523 }], # OS=="mac" or OS=="win" 504 }], # OS=="mac" or OS=="win"
524 ], 505 ],
525 } 506 }
OLDNEW
« no previous file with comments | « chrome/chrome.gyp ('k') | chrome/chrome_dll_syzygy.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698