Make drag and drop work on webpage. Also slightly modify drag drop workflow.

Make drag and drop work on webpage. Also slightly modify drag drop workflow.

BUG=97845
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112241

[Ben Goodger (Google), 2011-11-28 17:07:44]

Very cool!

http://codereview.chromium.org/8682029/diff/6001/chrome/browser/ui/views/tab_...
File chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.cc
(right):

http://codereview.chromium.org/8682029/diff/6001/chrome/browser/ui/views/tab_...
chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.cc:55:
aura::Window* window = static_cast<aura::Window*>(
Cast unnecessary.

http://codereview.chromium.org/8682029/diff/6001/chrome/browser/ui/views/tab_...
chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.cc:256: 
Can we add a section marker here:

/////...etc
// NativeTabContentsViewAura, private:

http://codereview.chromium.org/8682029/diff/6001/chrome/browser/ui/views/tab_...
chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.cc:257: void
NativeTabContentsViewAura::PrepareDragData(
Any of these functions that don't work with local state on the class can just be
defined in an anonymous namespace at the top of this file. It makes rebuilds
faster if these functions change signature.

http://codereview.chromium.org/8682029/diff/6001/chrome/browser/ui/views/tab_...
chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.cc:269: const
ui::OSExchangeData& data) {
ditto

http://codereview.chromium.org/8682029/diff/6001/chrome/browser/ui/views/tab_...
chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.cc:283: int
NativeTabContentsViewAura::ConvertFromWeb(
ditto

http://codereview.chromium.org/8682029/diff/6001/chrome/browser/ui/views/tab_...
chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.cc:296: int
drag_op) {
ditto

http://codereview.chromium.org/8682029/diff/6001/chrome/browser/ui/views/tab_...
chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.cc:311:
aura::Window* window = static_cast<aura::Window*>(
This cast isn't necessary. NativeView typedefs to aura::Window*

[varunjain, 2011-11-28 17:32:29]

http://codereview.chromium.org/8682029/diff/6001/chrome/browser/ui/views/tab_...
File chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.cc
(right):

http://codereview.chromium.org/8682029/diff/6001/chrome/browser/ui/views/tab_...
chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.cc:55:
aura::Window* window = static_cast<aura::Window*>(
On 2011/11/28 17:07:44, Ben Goodger (Google) wrote:
> Cast unnecessary.

Done.

http://codereview.chromium.org/8682029/diff/6001/chrome/browser/ui/views/tab_...
chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.cc:256: 
On 2011/11/28 17:07:44, Ben Goodger (Google) wrote:
> Can we add a section marker here:
> 
> /////...etc
> // NativeTabContentsViewAura, private:

Done.

http://codereview.chromium.org/8682029/diff/6001/chrome/browser/ui/views/tab_...
chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.cc:257: void
NativeTabContentsViewAura::PrepareDragData(
On 2011/11/28 17:07:44, Ben Goodger (Google) wrote:
> Any of these functions that don't work with local state on the class can just
be
> defined in an anonymous namespace at the top of this file. It makes rebuilds
> faster if these functions change signature.

Done.

http://codereview.chromium.org/8682029/diff/6001/chrome/browser/ui/views/tab_...
chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.cc:269: const
ui::OSExchangeData& data) {
On 2011/11/28 17:07:44, Ben Goodger (Google) wrote:
> ditto

Done.

http://codereview.chromium.org/8682029/diff/6001/chrome/browser/ui/views/tab_...
chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.cc:283: int
NativeTabContentsViewAura::ConvertFromWeb(
On 2011/11/28 17:07:44, Ben Goodger (Google) wrote:
> ditto

Done.

http://codereview.chromium.org/8682029/diff/6001/chrome/browser/ui/views/tab_...
chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.cc:296: int
drag_op) {
On 2011/11/28 17:07:44, Ben Goodger (Google) wrote:
> ditto

Done.

http://codereview.chromium.org/8682029/diff/6001/chrome/browser/ui/views/tab_...
chrome/browser/ui/views/tab_contents/native_tab_contents_view_aura.cc:311:
aura::Window* window = static_cast<aura::Window*>(
On 2011/11/28 17:07:44, Ben Goodger (Google) wrote:
> This cast isn't necessary. NativeView typedefs to aura::Window*

Done.

[Ben Goodger (Google), 2011-11-30 15:53:27]

lgtm

[commit-bot: I haz the power, 2011-11-30 16:09:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varunjain@chromium.org/8682029/10001

[commit-bot: I haz the power, 2011-11-30 17:12:00]

Change committed as 112241