Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: ui/aura_shell/drag_drop_controller_unittest.cc

Issue 8682029: Make drag and drop work on webpage. Also slightly modify drag drop workflow. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: modified according to comments Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/aura_shell/drag_drop_controller.cc ('k') | ui/views/widget/native_widget_aura.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/aura_shell/drag_drop_controller_unittest.cc
diff --git a/ui/aura_shell/drag_drop_controller_unittest.cc b/ui/aura_shell/drag_drop_controller_unittest.cc
index a153ceeea7b2d8f690f3ec48c89ab29936efcfd9..3ebdbdce061144fff6bbe514773566b41adadaf0 100644
--- a/ui/aura_shell/drag_drop_controller_unittest.cc
+++ b/ui/aura_shell/drag_drop_controller_unittest.cc
@@ -119,11 +119,11 @@ class TestDragDropController : public internal::DragDropController {
string16 drag_string_;
private:
- void StartDragAndDrop(const ui::OSExchangeData& data,
- int operation) OVERRIDE {
- DragDropController::StartDragAndDrop(data, operation);
+ int StartDragAndDrop(const ui::OSExchangeData& data,
+ int operation) OVERRIDE {
drag_start_received_ = true;
data.GetString(&drag_string_);
+ return DragDropController::StartDragAndDrop(data, operation);
}
void DragUpdate(aura::Window* target,
@@ -358,7 +358,7 @@ TEST_F(DragDropControllerTest, DragDropInMultipleViewsMultipleWidgetsTest) {
EXPECT_TRUE(drag_view1->drag_done_received_);
EXPECT_EQ(1, drag_view2->num_drag_enters_);
- num_expected_updates = num_drags - num_expected_updates - 2;
+ num_expected_updates = num_drags - num_expected_updates - 1;
EXPECT_EQ(num_expected_updates, drag_view2->num_drag_updates_);
EXPECT_EQ(1, drag_view2->num_drops_);
EXPECT_EQ(0, drag_view2->num_drag_exits_);
« no previous file with comments | « ui/aura_shell/drag_drop_controller.cc ('k') | ui/views/widget/native_widget_aura.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698