Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Issue 8682014: Fix layout test expectations. (Closed)

Created:
9 years ago by John Knottenbelt
Modified:
8 years, 11 months ago
Reviewers:
laforge, Chris Evans
CC:
chromium-reviews
Visibility:
Public.

Description

Fix layout test expectations.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M platform/chromium/test_expectations.txt View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
John Knottenbelt
This should fix the layout test expectations on the 912 branch so that the webkit ...
9 years ago (2011-11-23 18:04:02 UTC) #1
John Knottenbelt
9 years ago (2011-11-23 18:12:24 UTC) #2
Chris Evans
On 2011/11/23 18:04:02, John Knottenbelt wrote: > This should fix the layout test expectations on ...
9 years ago (2011-11-23 18:13:40 UTC) #3
laforge
LGTM On 2011/11/23 18:13:40, Chris Evans wrote: > On 2011/11/23 18:04:02, John Knottenbelt wrote: > ...
9 years ago (2011-11-24 00:51:43 UTC) #4
M-A Ruel
On 2011/11/24 00:51:43, laforge wrote: > LGTM > > On 2011/11/23 18:13:40, Chris Evans wrote: ...
8 years, 11 months ago (2012-01-04 19:54:58 UTC) #5
John Knottenbelt
8 years, 11 months ago (2012-01-05 10:07:30 UTC) #6
Thanks. I committed manually already. 

On 2012/01/04 19:54:58, Marc-Antoine Ruel wrote:
> On 2011/11/24 00:51:43, laforge wrote:
> > LGTM
> > 
> > On 2011/11/23 18:13:40, Chris Evans wrote:
> > > On 2011/11/23 18:04:02, John Knottenbelt wrote:
> > > > This should fix the layout test expectations on the 912 branch so that
the
> > > > webkit layout tests can run.
> > > 
> > > LGTM
> 
> You cannot use the CQ to commit in a local branch of webkit. Please commit
> manually.

Powered by Google App Engine
This is Rietveld 408576698